[serve] Added validation for lookback_period_s > metrics interval and updated docs#59456
Merged
abrarsheikh merged 6 commits intoray-project:masterfrom Dec 16, 2025
Merged
Conversation
…action Signed-off-by: Vaishnavi Panchavati <vaishdho10@gmail.com>
Signed-off-by: Vaishnavi Panchavati <vaishdho10@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a validation to ensure look_back_period_s is greater than metrics_interval_s in AutoscalingConfig and updates the documentation to clarify the relationship between autoscaling delays and metric push intervals. The code changes are correct and the tests are adequate. However, I found one issue where the documentation was not fully updated to reflect the new, stricter validation rule. Please see my comment for details.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Signed-off-by: Vaishnavi Panchavati <vaishdho10@gmail.com>
ray-gardener
bot
added
serve
Signed-off-by: Vaishnavi Panchavati <vaishdho10@gmail.com>
abrarsheikh
reviewed
Dec 16, 2025
python/ray/serve/config.py
Outdated
Comment on lines
+530
to
+533
| raise ValueError( | ||
| f"look_back_period_s ({v}) must be greater than " | ||
| f"metrics_interval_s ({metrics_interval_s})!" | ||
| ) |
Contributor
There was a problem hiding this comment.
i am thinking failing loudly may be too aggressive. How about we raise warning for now, then in 2 releases start raising exception.
Signed-off-by: Vaishnavi Panchavati <vaishdho10@gmail.com>
Signed-off-by: Vaishnavi Panchavati <vaishdho10@gmail.com>
abrarsheikh
approved these changes
Dec 16, 2025
cszhu
pushed a commit
that referenced
this pull request
Dec 17, 2025
…nd updated docs (#59456) ## Description - Added config validation to ensure `look_back_period_s` is greater than `metrics_interval_s` in `AutoscalingConfig`. - Updated autoscaling docs to clarify the relationship between delays and metric push intervals. ## Related issues Fixes #57714 ## Additional information - Updated documentation around the interaction between metrics push interval and autoscaling delays: Delays are enforced purely via the control loop interval and delay parameters, while the push interval bounds how quickly the autoscaler can see metric changes. --------- Signed-off-by: Vaishnavi Panchavati <vaishdho10@gmail.com>
zzchun
pushed a commit
to zzchun/ray
that referenced
this pull request
Dec 18, 2025
…nd updated docs (ray-project#59456) ## Description - Added config validation to ensure `look_back_period_s` is greater than `metrics_interval_s` in `AutoscalingConfig`. - Updated autoscaling docs to clarify the relationship between delays and metric push intervals. ## Related issues Fixes ray-project#57714 ## Additional information - Updated documentation around the interaction between metrics push interval and autoscaling delays: Delays are enforced purely via the control loop interval and delay parameters, while the push interval bounds how quickly the autoscaler can see metric changes. --------- Signed-off-by: Vaishnavi Panchavati <vaishdho10@gmail.com>
Yicheng-Lu-llll
pushed a commit
to Yicheng-Lu-llll/ray
that referenced
this pull request
Dec 22, 2025
…nd updated docs (ray-project#59456) ## Description - Added config validation to ensure `look_back_period_s` is greater than `metrics_interval_s` in `AutoscalingConfig`. - Updated autoscaling docs to clarify the relationship between delays and metric push intervals. ## Related issues Fixes ray-project#57714 ## Additional information - Updated documentation around the interaction between metrics push interval and autoscaling delays: Delays are enforced purely via the control loop interval and delay parameters, while the push interval bounds how quickly the autoscaler can see metric changes. --------- Signed-off-by: Vaishnavi Panchavati <vaishdho10@gmail.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
…nd updated docs (ray-project#59456) ## Description - Added config validation to ensure `look_back_period_s` is greater than `metrics_interval_s` in `AutoscalingConfig`. - Updated autoscaling docs to clarify the relationship between delays and metric push intervals. ## Related issues Fixes ray-project#57714 ## Additional information - Updated documentation around the interaction between metrics push interval and autoscaling delays: Delays are enforced purely via the control loop interval and delay parameters, while the push interval bounds how quickly the autoscaler can see metric changes. --------- Signed-off-by: Vaishnavi Panchavati <vaishdho10@gmail.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
look_back_period_sis greater thanmetrics_interval_sinAutoscalingConfig.Related issues
Fixes #57714
Additional information