[RLlib] remove MLAgents dependency#59524
Conversation
Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com>
Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com>
Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com>
Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com>
Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com>
Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com>
There was a problem hiding this comment.
Code Review
This pull request effectively removes the mlagents and mlagents_envs dependencies from RLlib. The changes are comprehensive, covering not only the package requirements but also the associated code for Unity3D environment wrappers, example scripts, documentation, and CI configurations. The removals are clean and consistent with the goal of reducing dependency clutter. The code base is now cleaner and has one less external dependency to maintain. The changes look good and I approve of this cleanup.
simonsays1980
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the PR @kamil-kaczmarek! Before merging let's discuss today in the meeting - this would remove a guideline for users who are working with the new stack on UnityEngine.
## Description This pull request removes Unity3D-based environments (`mlagents` and `mlagents_envs`) from RLlib, including dependencies, code, documentation, and related test requirements. The main goal is to clean up the requirements dependency. --------- Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com>
## Description This pull request removes Unity3D-based environments (`mlagents` and `mlagents_envs`) from RLlib, including dependencies, code, documentation, and related test requirements. The main goal is to clean up the requirements dependency. --------- Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com> Signed-off-by: jasonwrwang <jasonwrwang@tencent.com>
## Description This pull request removes Unity3D-based environments (`mlagents` and `mlagents_envs`) from RLlib, including dependencies, code, documentation, and related test requirements. The main goal is to clean up the requirements dependency. --------- Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com>
## Description This pull request removes Unity3D-based environments (`mlagents` and `mlagents_envs`) from RLlib, including dependencies, code, documentation, and related test requirements. The main goal is to clean up the requirements dependency. --------- Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
Description
This pull request removes Unity3D-based environments (
mlagentsandmlagents_envs) from RLlib, including dependencies, code, documentation, and related test requirements.The main goal is to clean up the requirements dependency.