Skip to content

[rllib] upgrade to gymnasium v1.2.2#59530

Merged
aslonnie merged 9 commits intomasterfrom
lonnie-251217-gymup
Dec 18, 2025
Merged

[rllib] upgrade to gymnasium v1.2.2#59530
aslonnie merged 9 commits intomasterfrom
lonnie-251217-gymup

Conversation

@aslonnie
Copy link
Collaborator

as we do not need to support python 3.9 anymore

@aslonnie aslonnie requested review from a team, edoakes and richardliaw as code owners December 18, 2025 03:31
@aslonnie aslonnie changed the title [rllib] upgrade to Gymnasium v1.2.2 [rllib] upgrade to gymnasium v1.2.2 Dec 18, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the gymnasium dependency from version 1.1.1 to 1.2.2. The change is applied consistently across all relevant files, including setup.py, requirements.txt, and numerous dependency lock files. The version bump is in line with the PR's goal to move to a version that no longer supports Python 3.9. The changes appear correct and comprehensive. No issues were found in the provided patches.

@aslonnie aslonnie added the go add ONLY when ready to merge, run all tests label Dec 18, 2025
Copy link
Contributor

@kamil-kaczmarek kamil-kaczmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aslonnie aslonnie enabled auto-merge (squash) December 18, 2025 04:44
@aslonnie
Copy link
Collaborator Author

most rllib tests are not even triggered.. I will just get this merged for now.

@aslonnie aslonnie disabled auto-merge December 18, 2025 05:00
@aslonnie
Copy link
Collaborator Author

actually, let me manually trigger some..

@aslonnie
Copy link
Collaborator Author

smoke test here: https://buildkite.com/ray-project/postmerge/builds/15032

@ray-gardener ray-gardener bot added the rllib RLlib related issues label Dec 18, 2025
@pseudo-rnd-thoughts
Copy link
Member

why is gymnasium a requirement for llm and other non-rllib components of ray?

@aslonnie aslonnie merged commit e4758d3 into master Dec 18, 2025
8 checks passed
@aslonnie aslonnie deleted the lonnie-251217-gymup branch December 18, 2025 12:26
@aslonnie
Copy link
Collaborator Author

why is gymnasium a requirement for llm and other non-rllib components of ray?

ray[all] dependencies are always installed in all ray images.

@Yicheng-Lu-llll
Copy link
Member

Hi @aslonnie — it looks like the Windows build is currently failing due to a dependency resolution issue with gymnasium==1.2.2. I’ve included the relevant logs below for context:

[2025-12-18T22:49:58Z]   Downloading fastapi-0.121.0-py3-none-any.whl.metadata (28 kB)
--
[2025-12-18T22:49:58Z] ERROR: Cannot install gymnasium==1.2.2 because these package versions have conflicting dependencies.
[2025-12-18T22:49:58Z]
[2025-12-18T22:49:58Z] The conflict is caused by:
[2025-12-18T22:49:58Z]     The user requested gymnasium==1.2.2
[2025-12-18T22:49:58Z]     The user requested (constraint) gymnasium==1.2.2
[2025-12-18T22:49:58Z]
[2025-12-18T22:49:58Z] Additionally, some packages in these conflicts have no matching distributions available for your environment:
[2025-12-18T22:49:58Z]     gymnasium
[2025-12-18T22:49:58Z]
[2025-12-18T22:49:58Z] To fix this you could try to:
[2025-12-18T22:49:58Z] 1. loosen the range of package versions you've specified
[2025-12-18T22:49:58Z] 2. remove package versions to allow pip to attempt to solve the dependency conflict
[2025-12-18T22:49:58Z]
[2025-12-18T22:49:58Z] ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts
[2025-12-18T22:50:08Z] The command 'powershell -Command $ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue'; bash ci/ray_ci/windows/build_base.sh' returned a non-zero code: 1
[2025-12-18T22:50:08Z] 2025/12/18 22:50:08 build docker: exit status 1
[2025-12-18T22:50:08Z] 🚨 Error: The command exited with status 1

https://buildkite.com/ray-project/premerge/builds/56185/steps/canvas?sid=019b3391-248c-48d5-8c95-a283009e842b#019b339d-3334-4983-9aee-a182fd7a09ea/L412

Would it be possible to temporarily revert the gymnasium version to the previous one, thanks!

Yicheng-Lu-llll pushed a commit to Yicheng-Lu-llll/ray that referenced this pull request Dec 19, 2025
@aslonnie
Copy link
Collaborator Author

should be fixed on master with #59572 now.

Yicheng-Lu-llll pushed a commit to Yicheng-Lu-llll/ray that referenced this pull request Dec 19, 2025
Yicheng-Lu-llll pushed a commit to Yicheng-Lu-llll/ray that referenced this pull request Dec 22, 2025
as we do not need to support python 3.9 anymore

---------

Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Co-authored-by: Mark Towers <mark@anyscale.com>
Co-authored-by: Mark Towers <mark.m.towers@gmail.com>
Yicheng-Lu-llll pushed a commit to Yicheng-Lu-llll/ray that referenced this pull request Dec 22, 2025
This reverts commit e4758d3.

Signed-off-by: yicheng <yicheng@anyscale.com>
Yicheng-Lu-llll pushed a commit to Yicheng-Lu-llll/ray that referenced this pull request Dec 22, 2025
…""

This reverts commit c604b8f.

Signed-off-by: yicheng <yicheng@anyscale.com>
ArturNiederfahrenhorst pushed a commit that referenced this pull request Dec 29, 2025
## Description
bump gymnasium to 1.2.2 in byod-rllib
follow up on:
* #59530

related:
* #59572

Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com>
AYou0207 pushed a commit to AYou0207/ray that referenced this pull request Jan 13, 2026
## Description
bump gymnasium to 1.2.2 in byod-rllib
follow up on:
* ray-project#59530

related:
* ray-project#59572

Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com>
Signed-off-by: jasonwrwang <jasonwrwang@tencent.com>
lee1258561 pushed a commit to pinterest/ray that referenced this pull request Feb 3, 2026
## Description
bump gymnasium to 1.2.2 in byod-rllib
follow up on:
* ray-project#59530

related:
* ray-project#59572

Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com>
peterxcli pushed a commit to peterxcli/ray that referenced this pull request Feb 25, 2026
as we do not need to support python 3.9 anymore

---------

Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Co-authored-by: Mark Towers <mark@anyscale.com>
Co-authored-by: Mark Towers <mark.m.towers@gmail.com>
Signed-off-by: peterxcli <peterxcli@gmail.com>
peterxcli pushed a commit to peterxcli/ray that referenced this pull request Feb 25, 2026
## Description
bump gymnasium to 1.2.2 in byod-rllib
follow up on:
* ray-project#59530

related:
* ray-project#59572

Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com>
Signed-off-by: peterxcli <peterxcli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests rllib RLlib related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants