Fix uv_runtime_env_hook.py to pin worker Python version#59768
Merged
edoakes merged 3 commits intoray-project:masterfrom Jan 21, 2026
Merged
Fix uv_runtime_env_hook.py to pin worker Python version#59768edoakes merged 3 commits intoray-project:masterfrom
uv_runtime_env_hook.py to pin worker Python version#59768edoakes merged 3 commits intoray-project:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a potential Python version mismatch between the Ray driver and workers when using uv run. The fix correctly pins the worker's Python version by adding the --python argument to the uv run command. The logic for determining the Python version to use is sound, with a clear order of precedence that prioritizes user-specified settings and falls back to the driver's Python version. This effectively prevents version conflicts and related crashes. My review includes one minor suggestion to use a more idiomatic and slightly more performant way to extend a list in Python.
ray-gardener
bot
added
core
edoakes
approved these changes
Jan 2, 2026
Collaborator
|
@dlwh please sign off the commits to fix DCO check |
… run`. This change ensures compatibility between the Ray driver and the worker by specifying the Python version, preventing version mismatches. Related issue: ray-project#59639. Signed-off-by: David Hall <david.hall@openathena.ai>
dlwh
force-pushed
the
fix_uv_python_version
branch
from
90a9d0d to
b0fa438
Compare
Contributor
Author
|
done sorry! |
Signed-off-by: David Hall <david.hall@openathena.ai>
Collaborator
|
Looks like |
dlwh
force-pushed
the
fix_uv_python_version
branch
from
af98368 to
4be663a
Compare
|
This pull request has been automatically marked as stale because it has not had You can always ask for help on our discussion forum or Ray's public slack channel. If you'd like to keep this open, just leave any comment, and the stale label will be removed. |
github-actions
bot
added
the
stale
jinbum-kim
pushed a commit
to jinbum-kim/ray
that referenced
this pull request
Jan 29, 2026
…t#59768) ## Description Fix `uv_runtime_env_hook.py` to pin worker Python version to driver version. If the system python version is different from the driver python version, you can end up with a mismatch between python versions (e.g. driver 3.11 vs worker 3.12), which causes Ray to deliberately crash elsewhere. This change ensures compatibility between the Ray driver and the worker by specifying the Python version, preventing version mismatches. ## Related issues Fixes ray-project#59639. ## Additional information --------- Signed-off-by: David Hall <david.hall@openathena.ai> Signed-off-by: jinbum-kim <jinbum9958@gmail.com>
400Ping
pushed a commit
to 400Ping/ray
that referenced
this pull request
Feb 1, 2026
…t#59768) ## Description Fix `uv_runtime_env_hook.py` to pin worker Python version to driver version. If the system python version is different from the driver python version, you can end up with a mismatch between python versions (e.g. driver 3.11 vs worker 3.12), which causes Ray to deliberately crash elsewhere. This change ensures compatibility between the Ray driver and the worker by specifying the Python version, preventing version mismatches. ## Related issues Fixes ray-project#59639. ## Additional information --------- Signed-off-by: David Hall <david.hall@openathena.ai> Signed-off-by: 400Ping <jiekaichang@apache.org>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Feb 3, 2026
…t#59768) ## Description Fix `uv_runtime_env_hook.py` to pin worker Python version to driver version. If the system python version is different from the driver python version, you can end up with a mismatch between python versions (e.g. driver 3.11 vs worker 3.12), which causes Ray to deliberately crash elsewhere. This change ensures compatibility between the Ray driver and the worker by specifying the Python version, preventing version mismatches. ## Related issues Fixes ray-project#59639. ## Additional information --------- Signed-off-by: David Hall <david.hall@openathena.ai>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
…t#59768) ## Description Fix `uv_runtime_env_hook.py` to pin worker Python version to driver version. If the system python version is different from the driver python version, you can end up with a mismatch between python versions (e.g. driver 3.11 vs worker 3.12), which causes Ray to deliberately crash elsewhere. This change ensures compatibility between the Ray driver and the worker by specifying the Python version, preventing version mismatches. ## Related issues Fixes ray-project#59639. ## Additional information --------- Signed-off-by: David Hall <david.hall@openathena.ai> Signed-off-by: peterxcli <peterxcli@gmail.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
…t#59768) ## Description Fix `uv_runtime_env_hook.py` to pin worker Python version to driver version. If the system python version is different from the driver python version, you can end up with a mismatch between python versions (e.g. driver 3.11 vs worker 3.12), which causes Ray to deliberately crash elsewhere. This change ensures compatibility between the Ray driver and the worker by specifying the Python version, preventing version mismatches. ## Related issues Fixes ray-project#59639. ## Additional information --------- Signed-off-by: David Hall <david.hall@openathena.ai> Signed-off-by: peterxcli <peterxcli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
uv_runtime_env_hook.pyto pin worker Python version to driver version.If the system python version is different from the driver python version, you can end up with a mismatch between python versions (e.g. driver 3.11 vs worker 3.12), which causes Ray to deliberately crash elsewhere.
This change ensures compatibility between the Ray driver and the worker by specifying the Python version, preventing version mismatches.
Related issues
Fixes #59639.
Additional information