Merged
Conversation
Signed-off-by: abrar <abrar@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses flakiness in the Windows tests, specifically test_controller, by replacing fixed time.sleep calls with wait_for_condition. This is an excellent improvement that makes the tests more robust and less prone to race conditions by waiting for specific states to be met instead of relying on arbitrary time delays. The related change in BUILD.bazel to re-categorize test_controller.py is also a reasonable step to provide it with appropriate test execution resources. The changes are correct and effectively tackle the described problem. I have no further comments.
akyang-anyscale
approved these changes
Dec 30, 2025
AYou0207
pushed a commit
to AYou0207/ray
that referenced
this pull request
Jan 13, 2026
test_controller was timing out ``` [2025-12-30T19:04:59Z] //python/ray/serve/tests:test_controller TIMEOUT in 3 out of 3 in 60.1s ``` Signed-off-by: abrar <abrar@anyscale.com> Signed-off-by: jasonwrwang <jasonwrwang@tencent.com>
lee1258561
pushed a commit
to pinterest/ray
that referenced
this pull request
Feb 3, 2026
test_controller was timing out ``` [2025-12-30T19:04:59Z] //python/ray/serve/tests:test_controller TIMEOUT in 3 out of 3 in 60.1s ``` Signed-off-by: abrar <abrar@anyscale.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
test_controller was timing out ``` [2025-12-30T19:04:59Z] //python/ray/serve/tests:test_controller TIMEOUT in 3 out of 3 in 60.1s ``` Signed-off-by: abrar <abrar@anyscale.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
test_controller was timing out ``` [2025-12-30T19:04:59Z] //python/ray/serve/tests:test_controller TIMEOUT in 3 out of 3 in 60.1s ``` Signed-off-by: abrar <abrar@anyscale.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_controller was timing out