[Data] - Tabular form for Streaming Executor Op Metrics#59774
[Data] - Tabular form for Streaming Executor Op Metrics#59774raulchen merged 5 commits intoray-project:masterfrom
Conversation
Signed-off-by: Goutam <goutam@anyscale.com>
There was a problem hiding this comment.
Code Review
This pull request improves the readability of operator metrics in logs by rendering them in a tabular format instead of a JSON blob. The implementation is clean and includes a comprehensive test case. I've suggested a minor refactoring to the new formatting function to improve its clarity and efficiency.
Signed-off-by: Goutam <goutam@anyscale.com>
|
/gemini summary |
Summary of ChangesThis pull request significantly improves the user experience when inspecting Streaming Executor Operator Metrics by transforming the previously unstructured JSON log output into a clear, categorized, and tabular format. This change aims to make debugging and monitoring more efficient by presenting critical performance data in an easily digestible manner, allowing users to quickly grasp the state and performance of operators. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
|
|
|
||
| lines.append( | ||
| f"└{'─' * (cat_width + 2)}┴{'─' * (key_width + 2)}┴{'─' * (val_width + 2)}┘" | ||
| ) |
There was a problem hiding this comment.
use from ray._private.thirdparty.tabulate.tabulate import tabulate for tabulation
Signed-off-by: Goutam <goutam@anyscale.com>
Signed-off-by: Goutam <goutam@anyscale.com>
…59774) ## Description Instead of rendering a large json blob for Operator metrics, render the log in a tabular form for better readability. ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. --------- Signed-off-by: Goutam <goutam@anyscale.com> Signed-off-by: jasonwrwang <jasonwrwang@tencent.com>
…59774) ## Description Instead of rendering a large json blob for Operator metrics, render the log in a tabular form for better readability. ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. --------- Signed-off-by: Goutam <goutam@anyscale.com>
…59774) ## Description Instead of rendering a large json blob for Operator metrics, render the log in a tabular form for better readability. ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. --------- Signed-off-by: Goutam <goutam@anyscale.com>
…59774) ## Description Instead of rendering a large json blob for Operator metrics, render the log in a tabular form for better readability. ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. --------- Signed-off-by: Goutam <goutam@anyscale.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
…59774) ## Description Instead of rendering a large json blob for Operator metrics, render the log in a tabular form for better readability. ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. --------- Signed-off-by: Goutam <goutam@anyscale.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
Description
Instead of rendering a large json blob for Operator metrics, render the log in a tabular form for better readability.
Related issues
Additional information