Skip to content

[macos] stop building python 3.9 wheels#59825

Merged
aslonnie merged 1 commit intoray-project:masterfrom
anyscale:lonnie-260103-macnopy39
Jan 4, 2026
Merged

[macos] stop building python 3.9 wheels#59825
aslonnie merged 1 commit intoray-project:masterfrom
anyscale:lonnie-260103-macnopy39

Conversation

@aslonnie
Copy link
Collaborator

@aslonnie aslonnie commented Jan 3, 2026

and remove python 3.9 related tests

and remove python 3.9 related tests

Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
@aslonnie aslonnie force-pushed the lonnie-260103-macnopy39 branch from 8b43331 to 2b6f9f4 Compare January 3, 2026 19:04
@aslonnie aslonnie added the go add ONLY when ready to merge, run all tests label Jan 3, 2026
@aslonnie aslonnie requested a review from a team January 3, 2026 19:05
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes Python 3.9 from the macOS wheel build and test scripts, which is a good cleanup. I've suggested a small improvement in ci/build/test-macos-wheels.sh to make the script more maintainable by deriving one version array from another, reducing the chance of future inconsistencies.

Comment on lines +47 to +48
PY_WHEEL_VERSIONS=("310" "311" "312")
PY_MMS=("3.10" "3.11" "3.12")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid having to manually sync PY_WHEEL_VERSIONS and PY_MMS, you can derive PY_WHEEL_VERSIONS from PY_MMS. This makes the script less prone to errors if Python versions are updated in the future.

Suggested change
PY_WHEEL_VERSIONS=("310" "311" "312")
PY_MMS=("3.10" "3.11" "3.12")
PY_MMS=("3.10")
PY_WHEEL_VERSIONS=("${PY_MMS[@]//./}")

@aslonnie aslonnie merged commit 4f2bb62 into ray-project:master Jan 4, 2026
8 checks passed
AYou0207 pushed a commit to AYou0207/ray that referenced this pull request Jan 13, 2026
and remove python 3.9 related tests

Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
Signed-off-by: jasonwrwang <jasonwrwang@tencent.com>
lee1258561 pushed a commit to pinterest/ray that referenced this pull request Feb 3, 2026
and remove python 3.9 related tests

Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Feb 3, 2026
and remove python 3.9 related tests

Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
peterxcli pushed a commit to peterxcli/ray that referenced this pull request Feb 25, 2026
and remove python 3.9 related tests

Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
Signed-off-by: peterxcli <peterxcli@gmail.com>
peterxcli pushed a commit to peterxcli/ray that referenced this pull request Feb 25, 2026
and remove python 3.9 related tests

Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
Signed-off-by: peterxcli <peterxcli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants