Skip to content

[Docs][Serve] Video analyses example for inferance#59859

Merged
abrarsheikh merged 24 commits intomasterfrom
SERVE-1495-abrar-vid
Jan 14, 2026
Merged

[Docs][Serve] Video analyses example for inferance#59859
abrarsheikh merged 24 commits intomasterfrom
SERVE-1495-abrar-vid

Conversation

@abrarsheikh
Copy link
Contributor

@abrarsheikh abrarsheikh commented Jan 5, 2026

added a notebook that demonstrates serve application that takes a reference to video as input and returns scene changes, tags and video description (from the corpus).

https://anyscale-ray--59859.com.readthedocs.build/en/59859/serve/tutorials/video-analysis/README.html

Signed-off-by: abrar <abrar@anyscale.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an excellent and comprehensive example for a video analysis pipeline using Ray Serve. The documentation, notebook, and supporting CI/release test configurations are well-structured. I've identified a few issues that should be addressed:

  • There's a critical issue in the release_tests.yaml configuration where an incorrect working_dir will cause the release test to fail.
  • A high-severity race condition exists in the S3 client initialization within the VideoAnalyzer deployment, which could lead to multiple clients being created under concurrent requests.
  • The documentation and notebook reference several image assets that are missing from the pull request, which will result in broken images.
  • I've also included a few medium-severity suggestions to improve code clarity and organization in the CI helper scripts.

Additionally, there are a couple of typos in the pull request title: "analyses" should be "analysis" and "inferance" should be "inference".

Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
@abrarsheikh abrarsheikh added the go add ONLY when ready to merge, run all tests label Jan 6, 2026
Signed-off-by: abrar <abrar@anyscale.com>
@abrarsheikh abrarsheikh marked this pull request as ready for review January 6, 2026 00:25
@abrarsheikh abrarsheikh requested review from a team as code owners January 6, 2026 00:25
@ray-gardener ray-gardener bot added serve Ray Serve Related Issue docs An issue or change related to documentation labels Jan 6, 2026
Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
print(inspect.getsource(VideoEncoder.func_or_class))
```

@serve.deployment(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this readme re-generated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, i think i generated it.

Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
@abrarsheikh abrarsheikh requested a review from dstrodtman January 8, 2026 03:51
Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
Copy link
Contributor

@dstrodtman dstrodtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

@abrarsheikh abrarsheikh enabled auto-merge (squash) January 14, 2026 00:22
@abrarsheikh abrarsheikh merged commit 458be78 into master Jan 14, 2026
7 checks passed
@abrarsheikh abrarsheikh deleted the SERVE-1495-abrar-vid branch January 14, 2026 00:29
rushikeshadhav pushed a commit to rushikeshadhav/ray that referenced this pull request Jan 14, 2026
added a notebook that demonstrates serve application that takes a
reference to video as input and returns scene changes, tags and video
description (from the corpus).


https://anyscale-ray--59859.com.readthedocs.build/en/59859/serve/tutorials/video-analysis/README.html

---------

Signed-off-by: abrar <abrar@anyscale.com>
jeffery4011 pushed a commit to jeffery4011/ray that referenced this pull request Jan 20, 2026
added a notebook that demonstrates serve application that takes a
reference to video as input and returns scene changes, tags and video
description (from the corpus).

https://anyscale-ray--59859.com.readthedocs.build/en/59859/serve/tutorials/video-analysis/README.html

---------

Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: jeffery4011 <jefferyshen1015@gmail.com>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Feb 3, 2026
added a notebook that demonstrates serve application that takes a
reference to video as input and returns scene changes, tags and video
description (from the corpus).


https://anyscale-ray--59859.com.readthedocs.build/en/59859/serve/tutorials/video-analysis/README.html

---------

Signed-off-by: abrar <abrar@anyscale.com>
peterxcli pushed a commit to peterxcli/ray that referenced this pull request Feb 25, 2026
added a notebook that demonstrates serve application that takes a
reference to video as input and returns scene changes, tags and video
description (from the corpus).

https://anyscale-ray--59859.com.readthedocs.build/en/59859/serve/tutorials/video-analysis/README.html

---------

Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: peterxcli <peterxcli@gmail.com>
peterxcli pushed a commit to peterxcli/ray that referenced this pull request Feb 25, 2026
added a notebook that demonstrates serve application that takes a
reference to video as input and returns scene changes, tags and video
description (from the corpus).

https://anyscale-ray--59859.com.readthedocs.build/en/59859/serve/tutorials/video-analysis/README.html

---------

Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: peterxcli <peterxcli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs An issue or change related to documentation go add ONLY when ready to merge, run all tests serve Ray Serve Related Issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants