[Core] Fix STRICT_PACK placement groups ignoring bundle label selectors#60170
Merged
edoakes merged 4 commits intoray-project:masterfrom Jan 16, 2026
Merged
Conversation
Signed-off-by: ryanaoleary <ryanaoleary@google.com>
Contributor
Author
|
cc: @MengjinYan |
8 tasks
ray-gardener
bot
added
core
MengjinYan
reviewed
Jan 15, 2026
Signed-off-by: ryanaoleary <ryanaoleary@google.com>
Signed-off-by: ryanaoleary <ryanaoleary@google.com>
limarkdcunha
pushed a commit
to limarkdcunha/ray
that referenced
this pull request
Jan 18, 2026
…rs (ray-project#60170) ## Description This PR fixes a bug with `bundle_label_selector` and `STRICT_PACK` scheduling policy, where labels are dropped from the aggregated resource request and then not considered when selecting from the candidate nodes in `BundleStrictPackSchedulingPolicy`. We now filter the candidate nodes by checking the feasibility each resource request with the labels before aggregating them. This PR also adds better test coverage for the scheduling policies supported with https://docs.ray.io/en/latest/ray-core/api/doc/ray.util.placement_group.html and their interaction with label selectors. ## Related issues Contributes ray-project#51564 --------- Signed-off-by: ryanaoleary <ryanaoleary@google.com> Signed-off-by: Limark Dcunha <limarkdcunha@gmail.com>
jinbum-kim
pushed a commit
to jinbum-kim/ray
that referenced
this pull request
Jan 29, 2026
…rs (ray-project#60170) ## Description This PR fixes a bug with `bundle_label_selector` and `STRICT_PACK` scheduling policy, where labels are dropped from the aggregated resource request and then not considered when selecting from the candidate nodes in `BundleStrictPackSchedulingPolicy`. We now filter the candidate nodes by checking the feasibility each resource request with the labels before aggregating them. This PR also adds better test coverage for the scheduling policies supported with https://docs.ray.io/en/latest/ray-core/api/doc/ray.util.placement_group.html and their interaction with label selectors. ## Related issues Contributes ray-project#51564 --------- Signed-off-by: ryanaoleary <ryanaoleary@google.com> Signed-off-by: jinbum-kim <jinbum9958@gmail.com>
ryanaoleary
added a commit
to ryanaoleary/ray
that referenced
this pull request
Feb 3, 2026
…rs (ray-project#60170) ## Description This PR fixes a bug with `bundle_label_selector` and `STRICT_PACK` scheduling policy, where labels are dropped from the aggregated resource request and then not considered when selecting from the candidate nodes in `BundleStrictPackSchedulingPolicy`. We now filter the candidate nodes by checking the feasibility each resource request with the labels before aggregating them. This PR also adds better test coverage for the scheduling policies supported with https://docs.ray.io/en/latest/ray-core/api/doc/ray.util.placement_group.html and their interaction with label selectors. ## Related issues Contributes ray-project#51564 --------- Signed-off-by: ryanaoleary <ryanaoleary@google.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
…rs (ray-project#60170) ## Description This PR fixes a bug with `bundle_label_selector` and `STRICT_PACK` scheduling policy, where labels are dropped from the aggregated resource request and then not considered when selecting from the candidate nodes in `BundleStrictPackSchedulingPolicy`. We now filter the candidate nodes by checking the feasibility each resource request with the labels before aggregating them. This PR also adds better test coverage for the scheduling policies supported with https://docs.ray.io/en/latest/ray-core/api/doc/ray.util.placement_group.html and their interaction with label selectors. ## Related issues Contributes ray-project#51564 --------- Signed-off-by: ryanaoleary <ryanaoleary@google.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
…rs (ray-project#60170) ## Description This PR fixes a bug with `bundle_label_selector` and `STRICT_PACK` scheduling policy, where labels are dropped from the aggregated resource request and then not considered when selecting from the candidate nodes in `BundleStrictPackSchedulingPolicy`. We now filter the candidate nodes by checking the feasibility each resource request with the labels before aggregating them. This PR also adds better test coverage for the scheduling policies supported with https://docs.ray.io/en/latest/ray-core/api/doc/ray.util.placement_group.html and their interaction with label selectors. ## Related issues Contributes ray-project#51564 --------- Signed-off-by: ryanaoleary <ryanaoleary@google.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug with
bundle_label_selectorandSTRICT_PACKscheduling policy, where labels are dropped from the aggregated resource request and then not considered when selecting from the candidate nodes inBundleStrictPackSchedulingPolicy. We now filter the candidate nodes by checking the feasibility each resource request with the labels before aggregating them.This PR also adds better test coverage for the scheduling policies supported with https://docs.ray.io/en/latest/ray-core/api/doc/ray.util.placement_group.html and their interaction with label selectors.
Related issues
Contributes #51564