[Data] Expose logical rules via package exports by 400Ping · Pull Request #60296 · ray-project/ray

400Ping · 2026-01-19T12:01:22Z

Description

Goal

Make ray.data._internal.logical.rules a proper package entry point with short imports and alphabetized __all__.

Changes

Add/complete __all__ in rule modules and re-export via __init__.py.
Update imports to from ray.data._internal.logical.rules import ....
Keep helper imports module-scoped to avoid circular dependencies.

Related issues

Related to #60204

Additional information

gemini-code-assist

Code Review

This pull request refactors the ray.data._internal.logical.rules package to provide a single entry point for importing logical rules, which improves code organization and maintainability. The changes involve dynamically exporting symbols from submodules via __init__.py, adding __all__ to the respective rule modules, and updating import statements in consumers.

The implementation is clean and achieves the stated goal. I have one suggestion to make the dynamic exporting in __init__.py more robust by handling potential name collisions between modules.

python/ray/data/_internal/logical/rules/__init__.py

gemini-code-assist · 2026-01-21T04:37:12Z

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

bveeramani · 2026-01-21T05:14:43Z

python/ray/data/_internal/logical/rules/__init__.py

+This module dynamically imports each submodule in the package and re-exports
+names listed in the submodule's __all__ attribute. This allows callers to
+import rules directly from ray.data._internal.logical.rules.
+"""
+
+from importlib import import_module
+from pkgutil import iter_modules
+
+__all__ = []
+
+for _loader, _module_name, _is_pkg in iter_modules(__path__):
+    if _module_name.startswith("_"):
+        continue
+    _module = import_module(f"{__name__}.{_module_name}")
+    _exported_names = getattr(_module, "__all__", [])
+    for _name in _exported_names:
+        globals()[_name] = getattr(_module, _name)
+    __all__.extend(_exported_names)
+
+__all__.sort()


Rather than using a script, can we explicitly list out the dependencies? e.g., from .inherit_batch_format import ...? I think it'll be easier to read and maintain

done in 81215e3

Signed-off-by: 400Ping <jiekai.chang326@gmail.com> Signed-off-by: 400Ping <fourhundredping@gmail.com>

Signed-off-by: 400Ping <fourhundredping@gmail.com>

400Ping · 2026-01-21T10:05:45Z

Checked the microcheck error, doesn't seems to be related to this PR?

bveeramani

Nice. LGTM

## Description ### Goal Make ray.data._internal.logical.rules a proper package entry point with short imports and alphabetized `__all__`. ### Changes Add/complete `__all__` in rule modules and re-export via `__init__.py`. Update imports to `from ray.data._internal.logical.rules import ...`. Keep helper imports module-scoped to avoid circular dependencies. ## Related issues Related to ray-project#60204 ## Additional information --------- Signed-off-by: 400Ping <jiekai.chang326@gmail.com> Signed-off-by: 400Ping <fourhundredping@gmail.com> Co-authored-by: Balaji Veeramani <balaji@anyscale.com>

## Description ### Goal Make ray.data._internal.logical.rules a proper package entry point with short imports and alphabetized `__all__`. ### Changes Add/complete `__all__` in rule modules and re-export via `__init__.py`. Update imports to `from ray.data._internal.logical.rules import ...`. Keep helper imports module-scoped to avoid circular dependencies. ## Related issues Related to ray-project#60204 ## Additional information --------- Signed-off-by: 400Ping <jiekai.chang326@gmail.com> Signed-off-by: 400Ping <fourhundredping@gmail.com> Co-authored-by: Balaji Veeramani <balaji@anyscale.com> Signed-off-by: jinbum-kim <jinbum9958@gmail.com>

## Description ### Goal Make ray.data._internal.logical.rules a proper package entry point with short imports and alphabetized `__all__`. ### Changes Add/complete `__all__` in rule modules and re-export via `__init__.py`. Update imports to `from ray.data._internal.logical.rules import ...`. Keep helper imports module-scoped to avoid circular dependencies. ## Related issues Related to ray-project#60204 ## Additional information --------- Signed-off-by: 400Ping <jiekai.chang326@gmail.com> Signed-off-by: 400Ping <fourhundredping@gmail.com> Co-authored-by: Balaji Veeramani <balaji@anyscale.com> Signed-off-by: peterxcli <peterxcli@gmail.com>

400Ping requested a review from a team as a code owner January 19, 2026 12:01

400Ping marked this pull request as draft January 19, 2026 12:01

400Ping force-pushed the pr/rules branch from b454466 to 9b37193 Compare January 19, 2026 12:02

gemini-code-assist bot reviewed Jan 19, 2026

View reviewed changes

python/ray/data/_internal/logical/rules/__init__.py Outdated Show resolved Hide resolved

400Ping force-pushed the pr/rules branch 4 times, most recently from 55c601d to 366d2ca Compare January 19, 2026 15:53

400Ping marked this pull request as ready for review January 21, 2026 04:37

bveeramani reviewed Jan 21, 2026

View reviewed changes

ray-gardener bot added data Ray Data-related issues community-contribution Contributed by the community labels Jan 21, 2026

400Ping requested a review from bveeramani January 21, 2026 08:28

400Ping and others added 4 commits January 21, 2026 16:31

Expose logical rules via package exports

46adef4

Signed-off-by: 400Ping <jiekai.chang326@gmail.com> Signed-off-by: 400Ping <fourhundredping@gmail.com>

fix

f9a01e0

Signed-off-by: 400Ping <fourhundredping@gmail.com>

update

aea5d30

Signed-off-by: 400Ping <fourhundredping@gmail.com>

ci: retrigger

5ae55af

Signed-off-by: 400Ping <fourhundredping@gmail.com>

400Ping force-pushed the pr/rules branch from 6eb5785 to 5ae55af Compare January 21, 2026 08:31

bveeramani approved these changes Jan 22, 2026

View reviewed changes

Merge branch 'master' into pr/rules

64b2496

bveeramani enabled auto-merge (squash) January 22, 2026 19:36

github-actions bot disabled auto-merge January 22, 2026 19:36

github-actions bot added the go add ONLY when ready to merge, run all tests label Jan 22, 2026

bveeramani merged commit 1e4cb8c into ray-project:master Jan 23, 2026
8 checks passed

bveeramani mentioned this pull request Feb 16, 2026

[Data] Encapsulate optimization rules, logical operators, and datasources within packages #60204

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Data] Expose logical rules via package exports#60296

[Data] Expose logical rules via package exports#60296
bveeramani merged 5 commits intoray-project:masterfrom
400Ping:pr/rules

400Ping commented Jan 19, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

gemini-code-assist bot commented Jan 21, 2026

Uh oh!

bveeramani Jan 21, 2026

Uh oh!

400Ping Jan 21, 2026

Uh oh!

400Ping commented Jan 21, 2026

Uh oh!

bveeramani left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

400Ping commented Jan 19, 2026

Description

Goal

Changes

Related issues

Additional information

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gemini-code-assist bot commented Jan 21, 2026

Uh oh!

bveeramani Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

400Ping Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

400Ping commented Jan 21, 2026

Uh oh!

bveeramani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants