Skip to content

[RLlib] Fix LearnerGroup.load_module_state() and simultaneously mark as deprecated.#60354

Merged
ArturNiederfahrenhorst merged 15 commits intomasterfrom
kk/checkpoints
Jan 23, 2026
Merged

[RLlib] Fix LearnerGroup.load_module_state() and simultaneously mark as deprecated.#60354
ArturNiederfahrenhorst merged 15 commits intomasterfrom
kk/checkpoints

Conversation

@kamil-kaczmarek
Copy link
Contributor

@kamil-kaczmarek kamil-kaczmarek commented Jan 21, 2026

Description

  • allow to pass a path with cloud filesystem (for example gcs or s3) to the LearnerGroup.load_module_state().

  • mark LearnerGroup.load_module_state() as Deprecated. Users should use Algorithm.restore_from_path(path=..., component=...)

  • mark load_state_path field in the RLModuleSpec dataclass as Deprecated. Direct users to use Algorithm.restore_from_path(path=..., component=...).

  • add unit tests for LearnerGroup.load_module_state()

Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com>
Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com>
Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com>
Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com>
Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com>
@kamil-kaczmarek kamil-kaczmarek self-assigned this Jan 21, 2026
@kamil-kaczmarek kamil-kaczmarek requested a review from a team as a code owner January 21, 2026 03:01
@gemini-code-assist
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@kamil-kaczmarek kamil-kaczmarek added the rllib RLlib related issues label Jan 21, 2026
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com>
@kamil-kaczmarek kamil-kaczmarek added the go add ONLY when ready to merge, run all tests label Jan 22, 2026
@ArturNiederfahrenhorst ArturNiederfahrenhorst enabled auto-merge (squash) January 22, 2026 21:45
@ArturNiederfahrenhorst ArturNiederfahrenhorst merged commit e323fe1 into master Jan 23, 2026
7 of 8 checks passed
@ArturNiederfahrenhorst ArturNiederfahrenhorst deleted the kk/checkpoints branch January 23, 2026 00:27
xinyuangui2 pushed a commit to xinyuangui2/ray that referenced this pull request Jan 26, 2026
…k as deprecated. (ray-project#60354)

## Description

* allow to pass a path with cloud filesystem (for example `gcs` or `s3`)
to the `LearnerGroup.load_module_state()`.
* mark `LearnerGroup.load_module_state()` as Deprecated. Users should
use `Algorithm.restore_from_path(path=..., component=...)`

* mark `load_state_path` field in the `RLModuleSpec` dataclass as
Deprecated. Direct users to use `Algorithm.restore_from_path(path=...,
component=...)`.
* add unit tests for `LearnerGroup.load_module_state()`

---------

Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com>
jinbum-kim pushed a commit to jinbum-kim/ray that referenced this pull request Jan 29, 2026
…k as deprecated. (ray-project#60354)

## Description

* allow to pass a path with cloud filesystem (for example `gcs` or `s3`)
to the `LearnerGroup.load_module_state()`.
* mark `LearnerGroup.load_module_state()` as Deprecated. Users should
use `Algorithm.restore_from_path(path=..., component=...)`

* mark `load_state_path` field in the `RLModuleSpec` dataclass as
Deprecated. Direct users to use `Algorithm.restore_from_path(path=...,
component=...)`.
* add unit tests for `LearnerGroup.load_module_state()`

---------

Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com>
Signed-off-by: jinbum-kim <jinbum9958@gmail.com>
400Ping pushed a commit to 400Ping/ray that referenced this pull request Feb 1, 2026
…k as deprecated. (ray-project#60354)

## Description

* allow to pass a path with cloud filesystem (for example `gcs` or `s3`)
to the `LearnerGroup.load_module_state()`.
* mark `LearnerGroup.load_module_state()` as Deprecated. Users should
use `Algorithm.restore_from_path(path=..., component=...)`

* mark `load_state_path` field in the `RLModuleSpec` dataclass as
Deprecated. Direct users to use `Algorithm.restore_from_path(path=...,
component=...)`.
* add unit tests for `LearnerGroup.load_module_state()`

---------

Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com>
Signed-off-by: 400Ping <jiekaichang@apache.org>
peterxcli pushed a commit to peterxcli/ray that referenced this pull request Feb 25, 2026
…k as deprecated. (ray-project#60354)

## Description

* allow to pass a path with cloud filesystem (for example `gcs` or `s3`)
to the `LearnerGroup.load_module_state()`.
* mark `LearnerGroup.load_module_state()` as Deprecated. Users should
use `Algorithm.restore_from_path(path=..., component=...)`

* mark `load_state_path` field in the `RLModuleSpec` dataclass as
Deprecated. Direct users to use `Algorithm.restore_from_path(path=...,
component=...)`.
* add unit tests for `LearnerGroup.load_module_state()`

---------

Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com>
Signed-off-by: peterxcli <peterxcli@gmail.com>
peterxcli pushed a commit to peterxcli/ray that referenced this pull request Feb 25, 2026
…k as deprecated. (ray-project#60354)

## Description

* allow to pass a path with cloud filesystem (for example `gcs` or `s3`)
to the `LearnerGroup.load_module_state()`.
* mark `LearnerGroup.load_module_state()` as Deprecated. Users should
use `Algorithm.restore_from_path(path=..., component=...)`

* mark `load_state_path` field in the `RLModuleSpec` dataclass as
Deprecated. Direct users to use `Algorithm.restore_from_path(path=...,
component=...)`.
* add unit tests for `LearnerGroup.load_module_state()`

---------

Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com>
Signed-off-by: peterxcli <peterxcli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests rllib RLlib related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants