Skip to content

[Serve] Skip Windows-incompatible gRPC e2e tests#60356

Merged
aslonnie merged 2 commits intoray-project:masterfrom
eicherseiji:fix-windows-grpc-e2e-tests
Jan 21, 2026
Merged

[Serve] Skip Windows-incompatible gRPC e2e tests#60356
aslonnie merged 2 commits intoray-project:masterfrom
eicherseiji:fix-windows-grpc-e2e-tests

Conversation

@eicherseiji
Copy link
Contributor

@eicherseiji eicherseiji commented Jan 21, 2026 •
edited
Loading

Why are these changes needed?

Fixes anyscale#758

Skip test_no_spammy_errors_in_composed_app and test_no_spammy_errors_in_grpc_proxy on Windows due to:

  • Signal handling: test_no_spammy_errors_in_grpc_proxy uses p.send_signal(signal.SIGINT) which Windows doesn't support for subprocesses (raises ValueError: Unsupported signal: 2)
  • Temp directory cleanup: test_no_spammy_errors_in_composed_app writes replica logs to a temp directory, and Windows doesn't release file handles immediately after process termination, causing cleanup failures (NotADirectoryError: [WinError 267])

This follows the existing pattern from test_logging.py:1216 which skips similar tests on Windows:

@pytest.mark.skipif(sys.platform == "win32", reason="Fail to look for temp dir.")

Related issue number

anyscale#758

Checks

  • I've signed all my commits
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      temporary directory, causing NotADirectoryError on cleanup
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • [] Release tests
    • This PR is not tested :(

@eicherseiji
[Serve] Skip Windows-incompatible gRPC e2e tests
4427449 
Skip test_no_spammy_errors_in_composed_app and test_no_spammy_errors_in_grpc_proxy
on Windows due to:
- Signal handling: Windows doesn't support SIGINT for subprocesses
- Temp directory cleanup: File handles not released immediately after process termination

This follows the existing pattern from test_logging.py which skips similar tests on Windows.

Signed-off-by: Seiji Eicher <seiji@anyscale.com>
@eicherseiji eicherseiji requested a review from a team as a code owner January 21, 2026 04:53
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jan 21, 2026

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@eicherseiji eicherseiji added the go add ONLY when ready to merge, run all tests label Jan 21, 2026
abrarsheikh
abrarsheikh approved these changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@abrarsheikh abrarsheikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine to skip for now

@ray-gardener ray-gardener bot added the serve Ray Serve Related Issue label Jan 21, 2026
@aslonnie aslonnie merged commit 4518e93 into ray-project:master Jan 21, 2026
5 of 6 checks passed
@eicherseiji eicherseiji mentioned this pull request Jan 22, 2026
Merged
6 tasks
@ZacAttack ZacAttack mentioned this pull request Jan 22, 2026
Closed
jinbum-kim pushed a commit to jinbum-kim/ray that referenced this pull request Jan 29, 2026
@eicherseiji @jinbum-kim
[Serve] Skip Windows-incompatible gRPC e2e tests (ray-project#60356)
053f7b3 
## Why are these changes needed?

Fixes anyscale#758

Skip `test_no_spammy_errors_in_composed_app` and
`test_no_spammy_errors_in_grpc_proxy` on Windows due to:

- **Signal handling**: `test_no_spammy_errors_in_grpc_proxy` uses
`p.send_signal(signal.SIGINT)` which Windows doesn't support for
subprocesses (raises `ValueError: Unsupported signal: 2`)
- **Temp directory cleanup**: `test_no_spammy_errors_in_composed_app`
writes replica logs to a temp directory, and Windows doesn't release
file handles immediately after process termination, causing cleanup
failures (`NotADirectoryError: [WinError 267]`)

This follows the existing pattern from `test_logging.py:1216` which
skips similar tests on Windows:
```python
@pytest.mark.skipif(sys.platform == "win32", reason="Fail to look for temp dir.")
```

## Related issue number

anyscale#758

## Checks

- [x] I've signed all my commits
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
        temporary directory, causing `NotADirectoryError` on cleanup
method in Tune, I've added it in `doc/source/tune/api/` under the
        corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: jinbum-kim <jinbum9958@gmail.com>
400Ping pushed a commit to 400Ping/ray that referenced this pull request Feb 1, 2026
@eicherseiji @400Ping
[Serve] Skip Windows-incompatible gRPC e2e tests (ray-project#60356)
56d6292 
## Why are these changes needed?

Fixes anyscale#758

Skip `test_no_spammy_errors_in_composed_app` and
`test_no_spammy_errors_in_grpc_proxy` on Windows due to:

- **Signal handling**: `test_no_spammy_errors_in_grpc_proxy` uses
`p.send_signal(signal.SIGINT)` which Windows doesn't support for
subprocesses (raises `ValueError: Unsupported signal: 2`)
- **Temp directory cleanup**: `test_no_spammy_errors_in_composed_app`
writes replica logs to a temp directory, and Windows doesn't release
file handles immediately after process termination, causing cleanup
failures (`NotADirectoryError: [WinError 267]`)

This follows the existing pattern from `test_logging.py:1216` which
skips similar tests on Windows:
```python
@pytest.mark.skipif(sys.platform == "win32", reason="Fail to look for temp dir.")
```

## Related issue number

anyscale#758

## Checks

- [x] I've signed all my commits
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
        temporary directory, causing `NotADirectoryError` on cleanup
method in Tune, I've added it in `doc/source/tune/api/` under the
        corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: 400Ping <jiekaichang@apache.org>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Feb 3, 2026
@eicherseiji @ryanaoleary
[Serve] Skip Windows-incompatible gRPC e2e tests (ray-project#60356)
7fd263d 
## Why are these changes needed?

Fixes anyscale#758

Skip `test_no_spammy_errors_in_composed_app` and
`test_no_spammy_errors_in_grpc_proxy` on Windows due to:

- **Signal handling**: `test_no_spammy_errors_in_grpc_proxy` uses
`p.send_signal(signal.SIGINT)` which Windows doesn't support for
subprocesses (raises `ValueError: Unsupported signal: 2`)
- **Temp directory cleanup**: `test_no_spammy_errors_in_composed_app`
writes replica logs to a temp directory, and Windows doesn't release
file handles immediately after process termination, causing cleanup
failures (`NotADirectoryError: [WinError 267]`)

This follows the existing pattern from `test_logging.py:1216` which
skips similar tests on Windows:
```python
@pytest.mark.skipif(sys.platform == "win32", reason="Fail to look for temp dir.")
```

## Related issue number

anyscale#758

## Checks

- [x] I've signed all my commits
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
        temporary directory, causing `NotADirectoryError` on cleanup
method in Tune, I've added it in `doc/source/tune/api/` under the
        corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Seiji Eicher <seiji@anyscale.com>
peterxcli pushed a commit to peterxcli/ray that referenced this pull request Feb 25, 2026
@eicherseiji @peterxcli
[Serve] Skip Windows-incompatible gRPC e2e tests (ray-project#60356)
c348cf7 
## Why are these changes needed?

Fixes anyscale#758

Skip `test_no_spammy_errors_in_composed_app` and
`test_no_spammy_errors_in_grpc_proxy` on Windows due to:

- **Signal handling**: `test_no_spammy_errors_in_grpc_proxy` uses
`p.send_signal(signal.SIGINT)` which Windows doesn't support for
subprocesses (raises `ValueError: Unsupported signal: 2`)
- **Temp directory cleanup**: `test_no_spammy_errors_in_composed_app`
writes replica logs to a temp directory, and Windows doesn't release
file handles immediately after process termination, causing cleanup
failures (`NotADirectoryError: [WinError 267]`)

This follows the existing pattern from `test_logging.py:1216` which
skips similar tests on Windows:
```python
@pytest.mark.skipif(sys.platform == "win32", reason="Fail to look for temp dir.")
```

## Related issue number

anyscale#758

## Checks

- [x] I've signed all my commits
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
        temporary directory, causing `NotADirectoryError` on cleanup
method in Tune, I've added it in `doc/source/tune/api/` under the
        corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: peterxcli <peterxcli@gmail.com>
peterxcli pushed a commit to peterxcli/ray that referenced this pull request Feb 25, 2026
@eicherseiji @peterxcli
[Serve] Skip Windows-incompatible gRPC e2e tests (ray-project#60356)
35855a3 
## Why are these changes needed?

Fixes anyscale#758

Skip `test_no_spammy_errors_in_composed_app` and
`test_no_spammy_errors_in_grpc_proxy` on Windows due to:

- **Signal handling**: `test_no_spammy_errors_in_grpc_proxy` uses
`p.send_signal(signal.SIGINT)` which Windows doesn't support for
subprocesses (raises `ValueError: Unsupported signal: 2`)
- **Temp directory cleanup**: `test_no_spammy_errors_in_composed_app`
writes replica logs to a temp directory, and Windows doesn't release
file handles immediately after process termination, causing cleanup
failures (`NotADirectoryError: [WinError 267]`)

This follows the existing pattern from `test_logging.py:1216` which
skips similar tests on Windows:
```python
@pytest.mark.skipif(sys.platform == "win32", reason="Fail to look for temp dir.")
```

## Related issue number

anyscale#758

## Checks

- [x] I've signed all my commits
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
        temporary directory, causing `NotADirectoryError` on cleanup
method in Tune, I've added it in `doc/source/tune/api/` under the
        corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: peterxcli <peterxcli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abrarsheikh abrarsheikh abrarsheikh approved these changes

Assignees

No one assigned

Labels

go add ONLY when ready to merge, run all tests serve Ray Serve Related Issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI test windows://python/ray/serve/tests:test_grpc_e2e is consistently_failing

3 participants

@eicherseiji @abrarsheikh @aslonnie