[data][llm][doc] Add in resiliency section and refine doc code#60594
[data][llm][doc] Add in resiliency section and refine doc code#60594kouroshHakha merged 4 commits intomasterfrom
Conversation
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
17bbbed to
d4f0aee
Compare
…behavior Signed-off-by: Jeffrey Wang <jeffreywang@anyscale.com>
d4f0aee to
f9436c7
Compare
| ds = ray.data.read_parquet(input_path) | ||
| ds = processor(ds) | ||
| ds.write_parquet(output_path) | ||
| # __checkpoint_usage_example_end__ |
There was a problem hiding this comment.
Checkpoint demo runs during module import
High Severity
The new checkpoint example executes at import time: it deletes and recreates /tmp/llm_checkpoint_demo/*, sets global ray.data.DataContext checkpoint config, then calls ray.data.read_parquet(input_path) and write_parquet(output_path) without creating any input data. This can fail CI/docs builds and introduces unexpected filesystem and global state side effects.
doc/source/data/doc_code/working-with-llms/basic_llm_example.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Jeffrey Wang <jeffreywang@anyscale.com>
kouroshHakha
left a comment
There was a problem hiding this comment.
The docs have not compiled yet for me to check the rendered version but for now leaving this nit:
|
|
||
| .. literalinclude:: doc_code/working-with-llms/vlm_image_example.py | ||
| :language: python | ||
| :start-after: def load_vision_dataset(): |
There was a problem hiding this comment.
nit: use dedicated tags, rather than function names
There was a problem hiding this comment.
Addressed in the latest revision and confirmed that the doc rendered properly.
cc2573f to
e5200c7
Compare
…roject#60594) Signed-off-by: Jeffrey Wang <jeffreywang@anyscale.com> Signed-off-by: Sirui Huang <ray.huang@anyscale.com>
Signed-off-by: Jeffrey Wang <jeffreywang@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: Jeffrey Wang <jeffreywang@anyscale.com>
…roject#60594) Signed-off-by: Jeffrey Wang <jeffreywang@anyscale.com> Signed-off-by: Adel Nour <ans9868@nyu.edu>
…roject#60594) Signed-off-by: Jeffrey Wang <jeffreywang@anyscale.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
…roject#60594) Signed-off-by: Jeffrey Wang <jeffreywang@anyscale.com> Signed-off-by: peterxcli <peterxcli@gmail.com>



Description
chat_template_stage=Trueoverapply_chat_template=True)Related issues
Additional information