[core] (cgroups 25/n) Making cgroup_path a part of the public API for ray.init(...)#60726
Merged
[core] (cgroups 25/n) Making cgroup_path a part of the public API for ray.init(...)#60726
Conversation
ray.init(...) Signed-off-by: irabbani <israbbani@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request makes cgroup_path a public parameter in ray.init(), which is a sensible change given its necessity in non-privileged container environments. The implementation correctly updates the function signature, documentation, and internal usage. I have a couple of minor suggestions to improve the documentation's clarity and to clean up some leftover code.
israbbani
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Signed-off-by: irabbani <israbbani@gmail.com>
edoakes
approved these changes
Feb 3, 2026
Collaborator
|
Don't forget to update the docs page |
Contributor
Author
|
Yep waiting for this to merge and then I'll update the other PR. |
Kunchd
reviewed
Feb 4, 2026
Contributor
Kunchd
left a comment
Kunchd
left a comment
There was a problem hiding this comment.
Assuming, we probably want to modify scipt.py to make cgroup-path public as well: https://github.com/ray-project/ray/blob/master/python/ray/scripts/scripts.py#L672.
… irabbani/cgroups-21
Contributor
Author
Good point. Fixed |
tiennguyentony
pushed a commit
to tiennguyentony/ray
that referenced
this pull request
Feb 6, 2026
… ray.init(...) (ray-project#60726) Follow up from ray-project#60183. When not running inside privileged containers, the user will have to specify a `cgroup_path`. It makes sense for this to be a part of the public API for `ray.init(...)`. Things I'm changing 1. Promoting `cgroup_path` to a public API parameter for `ray.init` 2. Updating tests to use that parameter. 3. Running all cgroup tests on CI for all C++ and python changes. --------- Signed-off-by: irabbani <israbbani@gmail.com> Signed-off-by: tiennguyentony <46289799+tiennguyentony@users.noreply.github.com>
tiennguyentony
pushed a commit
to tiennguyentony/ray
that referenced
this pull request
Feb 7, 2026
… ray.init(...) (ray-project#60726) Follow up from ray-project#60183. When not running inside privileged containers, the user will have to specify a `cgroup_path`. It makes sense for this to be a part of the public API for `ray.init(...)`. Things I'm changing 1. Promoting `cgroup_path` to a public API parameter for `ray.init` 2. Updating tests to use that parameter. 3. Running all cgroup tests on CI for all C++ and python changes. --------- Signed-off-by: irabbani <israbbani@gmail.com> Signed-off-by: tiennguyentony <46289799+tiennguyentony@users.noreply.github.com>
tiennguyentony
pushed a commit
to tiennguyentony/ray
that referenced
this pull request
Feb 7, 2026
… ray.init(...) (ray-project#60726) Follow up from ray-project#60183. When not running inside privileged containers, the user will have to specify a `cgroup_path`. It makes sense for this to be a part of the public API for `ray.init(...)`. Things I'm changing 1. Promoting `cgroup_path` to a public API parameter for `ray.init` 2. Updating tests to use that parameter. 3. Running all cgroup tests on CI for all C++ and python changes. --------- Signed-off-by: irabbani <israbbani@gmail.com> Signed-off-by: tiennguyentony <46289799+tiennguyentony@users.noreply.github.com>
tiennguyentony
pushed a commit
to tiennguyentony/ray
that referenced
this pull request
Feb 7, 2026
… ray.init(...) (ray-project#60726) Follow up from ray-project#60183. When not running inside privileged containers, the user will have to specify a `cgroup_path`. It makes sense for this to be a part of the public API for `ray.init(...)`. Things I'm changing 1. Promoting `cgroup_path` to a public API parameter for `ray.init` 2. Updating tests to use that parameter. 3. Running all cgroup tests on CI for all C++ and python changes. --------- Signed-off-by: irabbani <israbbani@gmail.com> Signed-off-by: tiennguyentony <46289799+tiennguyentony@users.noreply.github.com>
tiennguyentony
pushed a commit
to tiennguyentony/ray
that referenced
this pull request
Feb 7, 2026
… ray.init(...) (ray-project#60726) Follow up from ray-project#60183. When not running inside privileged containers, the user will have to specify a `cgroup_path`. It makes sense for this to be a part of the public API for `ray.init(...)`. Things I'm changing 1. Promoting `cgroup_path` to a public API parameter for `ray.init` 2. Updating tests to use that parameter. 3. Running all cgroup tests on CI for all C++ and python changes. --------- Signed-off-by: irabbani <israbbani@gmail.com> Signed-off-by: tiennguyentony <46289799+tiennguyentony@users.noreply.github.com>
Sparks0219
pushed a commit
to Sparks0219/ray
that referenced
this pull request
Feb 9, 2026
… ray.init(...) (ray-project#60726) Follow up from ray-project#60183. When not running inside privileged containers, the user will have to specify a `cgroup_path`. It makes sense for this to be a part of the public API for `ray.init(...)`. Things I'm changing 1. Promoting `cgroup_path` to a public API parameter for `ray.init` 2. Updating tests to use that parameter. 3. Running all cgroup tests on CI for all C++ and python changes. --------- Signed-off-by: irabbani <israbbani@gmail.com>
elliot-barn
pushed a commit
that referenced
this pull request
Feb 9, 2026
… ray.init(...) (#60726) Follow up from #60183. When not running inside privileged containers, the user will have to specify a `cgroup_path`. It makes sense for this to be a part of the public API for `ray.init(...)`. Things I'm changing 1. Promoting `cgroup_path` to a public API parameter for `ray.init` 2. Updating tests to use that parameter. 3. Running all cgroup tests on CI for all C++ and python changes. --------- Signed-off-by: irabbani <israbbani@gmail.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Feb 9, 2026
… ray.init(...) (#60726) Follow up from #60183. When not running inside privileged containers, the user will have to specify a `cgroup_path`. It makes sense for this to be a part of the public API for `ray.init(...)`. Things I'm changing 1. Promoting `cgroup_path` to a public API parameter for `ray.init` 2. Updating tests to use that parameter. 3. Running all cgroup tests on CI for all C++ and python changes. --------- Signed-off-by: irabbani <israbbani@gmail.com>
ans9868
pushed a commit
to ans9868/ray
that referenced
this pull request
Feb 18, 2026
… ray.init(...) (ray-project#60726) Follow up from ray-project#60183. When not running inside privileged containers, the user will have to specify a `cgroup_path`. It makes sense for this to be a part of the public API for `ray.init(...)`. Things I'm changing 1. Promoting `cgroup_path` to a public API parameter for `ray.init` 2. Updating tests to use that parameter. 3. Running all cgroup tests on CI for all C++ and python changes. --------- Signed-off-by: irabbani <israbbani@gmail.com> Signed-off-by: Adel Nour <ans9868@nyu.edu>
Aydin-ab
pushed a commit
to kunling-anyscale/ray
that referenced
this pull request
Feb 20, 2026
… ray.init(...) (ray-project#60726) Follow up from ray-project#60183. When not running inside privileged containers, the user will have to specify a `cgroup_path`. It makes sense for this to be a part of the public API for `ray.init(...)`. Things I'm changing 1. Promoting `cgroup_path` to a public API parameter for `ray.init` 2. Updating tests to use that parameter. 3. Running all cgroup tests on CI for all C++ and python changes. --------- Signed-off-by: irabbani <israbbani@gmail.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
… ray.init(...) (ray-project#60726) Follow up from ray-project#60183. When not running inside privileged containers, the user will have to specify a `cgroup_path`. It makes sense for this to be a part of the public API for `ray.init(...)`. Things I'm changing 1. Promoting `cgroup_path` to a public API parameter for `ray.init` 2. Updating tests to use that parameter. 3. Running all cgroup tests on CI for all C++ and python changes. --------- Signed-off-by: irabbani <israbbani@gmail.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
… ray.init(...) (ray-project#60726) Follow up from ray-project#60183. When not running inside privileged containers, the user will have to specify a `cgroup_path`. It makes sense for this to be a part of the public API for `ray.init(...)`. Things I'm changing 1. Promoting `cgroup_path` to a public API parameter for `ray.init` 2. Updating tests to use that parameter. 3. Running all cgroup tests on CI for all C++ and python changes. --------- Signed-off-by: irabbani <israbbani@gmail.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #60183.
When not running inside privileged containers, the user will have to specify a
cgroup_path. It makes sense for this to be a part of the public API forray.init(...).Things I'm changing
cgroup_pathto a public API parameter forray.init