Add unfurl_links and unfurl_media to Message#130
Open
MaxLeiter wants to merge 1 commit intoraycharius:mainfrom
Open
Add unfurl_links and unfurl_media to Message#130MaxLeiter wants to merge 1 commit intoraycharius:mainfrom
MaxLeiter wants to merge 1 commit intoraycharius:mainfrom
Conversation
|
@raycharius could you please have a look this PR? |
james-gre
added a commit
to ExodusForks/slack-block-builder
that referenced
this pull request
Jan 11, 2026
Cherry-picked from PR raycharius#130 with bug fixes: - Fixed duplicate UnfurlLinks enum key (should be UnfurlMedia) - Fixed unfurlMedia method using wrong Prop (UnfurlLinks → UnfurlMedia) - Fixed unfurl-media.ts test using wrong Prop references Closes raycharius#119
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #119
I added it by following where the other values like
threadTsare used/tested, but I could have missed something. I can't run tests because of some TS issues:Should
@types/nodebe added as a dev dependency?I personally prefer snake_case for the parameters (so
unfurl_linksinstead ofunfurlLinks) but I kept it camelCase for consistency with the other code.