Fixed a bug in the 2d camera platformer example#2687
Merged
Conversation
canJump used to alternate between true and false when on ground
Owner
|
@skylar779 Good catch! Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
canJumpused to alternate betweentrueandfalsewhen on the ground.When using
IsKeyPressedinstead ofIsKeyDownfor jumping, the player might not jump due to that behavior. This behavior got fixed by adjusting the condition for checking if an obstacle is being hit. With this change,canJumpdoesn't alternate betweentrueandfalsewhen the player is on the ground and instead stays ontrue.