fix: QOA when using with LoadMusicStreamFromMemory#5108
Merged
Conversation
…r of allocs and memcpy
Owner
|
@lassade Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LoadMusicStreamFromMemory isn't working for QOA right now, this PR fixes it, the main issue was that
file_data_offsetshould be equal tofirst_frame_posmimicking FILE behaviour.I also joined the file data copy into a single malloc and removed the need of having an extra buffer when the data is already available. So overal it should do less malloc's and less memcpy's.