Skip to content

[rmodels] UpdateModelAnimation() reviewed matrix-transpose, only once per bone#5244

Merged
raysan5 merged 1 commit into
raysan5:masterfrom
Arrangemonk:Arrangemonk_FixAnimsample
Oct 15, 2025
Merged

[rmodels] UpdateModelAnimation() reviewed matrix-transpose, only once per bone#5244
raysan5 merged 1 commit into
raysan5:masterfrom
Arrangemonk:Arrangemonk_FixAnimsample

Conversation

@Arrangemonk
Copy link
Copy Markdown
Contributor

@Arrangemonk Arrangemonk commented Oct 8, 2025

i updated UpdateModelAnimation to calculate the inverted bone matrix only once per bone instead of for every vertex

i measured time and its only twice as fast as before, so its not much of an improvement but still better than nothing

@raysan5 raysan5 changed the title UpdateModelAnimation matrixtranspose only once per bone [rmodels] UpdateModelAnimation() reviewed matrix-transpose, only once per bone Oct 15, 2025
@raysan5 raysan5 merged commit e3a562a into raysan5:master Oct 15, 2025
@raysan5
Copy link
Copy Markdown
Owner

raysan5 commented Oct 15, 2025

@Arrangemonk thanks for the review!

@JeffM2501
Copy link
Copy Markdown
Contributor

Was this PR tested on any kind of complex model?
I understand what it's trying to solve, but the bone weight check is in the wrong place and will early out incorrect.
This looks like it only iterates 4 bones per model, not 4 bones per vertex.

I would remove this PR until the questions are answered or the code is fixed.

@raysan5
Copy link
Copy Markdown
Owner

raysan5 commented Oct 30, 2025

@Arrangemonk Please, could you check the questions from Jeff? We have some concerns about the correctness of this optimization...

@Arrangemonk
Copy link
Copy Markdown
Contributor Author

Arrangemonk commented Oct 30, 2025

@JeffM2501 @raysan5 , the tests with the robot model were misleading, im sorry for causing inconvenience, in the future im going to test my ideas thoroughly, before creating a pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants