[rmodels] UpdateModelAnimation() reviewed matrix-transpose, only once per bone#5244
Merged
Merged
Conversation
… bone instead of per vertex
UpdateModelAnimation() reviewed matrix-transpose, only once per bone
Owner
|
@Arrangemonk thanks for the review! |
Contributor
|
Was this PR tested on any kind of complex model? I would remove this PR until the questions are answered or the code is fixed. |
Owner
|
@Arrangemonk Please, could you check the questions from Jeff? We have some concerns about the correctness of this optimization... |
Contributor
Author
|
@JeffM2501 @raysan5 , the tests with the robot model were misleading, im sorry for causing inconvenience, in the future im going to test my ideas thoroughly, before creating a pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i updated UpdateModelAnimation to calculate the inverted bone matrix only once per bone instead of for every vertex
i measured time and its only twice as fast as before, so its not much of an improvement but still better than nothing