Bq proto abstractions #3
Conversation
lavkesh
force-pushed
the
bq-proto-abstractions
branch
from
af41a26 to
d535968
Compare
src/main/java/io/odpf/sink/connectors/bigquery/BigqueryStencilUpdateListenerFactory.java
Show resolved
Hide resolved
src/main/java/io/odpf/sink/connectors/bigquery/BigqueryStencilUpdateListenerFactory.java
Outdated
Show resolved
Hide resolved
|
|
||
| Map<String, Object> getMapping(); | ||
| } | ||
| void validate(OdpfSinkConfig config); |
There was a problem hiding this comment.
I am assuming validate will be used to check the configs and then after we will call getRaw or getMapping. However, it neither returns a boolean nor throws any exceptions. How will this be used ?
There was a problem hiding this comment.
yea we can think about the method signature. it can just log or throw runtime exception too, we don't have to declare RuntimeException.
src/main/java/io/odpf/sink/connectors/message/json/JsonOdpfMessageParser.java
Outdated
Show resolved
Hide resolved
src/main/java/io/odpf/sink/connectors/message/json/JsonOdpfMessageParser.java
Outdated
Show resolved
Hide resolved
src/main/java/io/odpf/sink/connectors/message/json/JsonOdpfMessageParser.java
Show resolved
Hide resolved
src/main/java/io/odpf/sink/connectors/message/proto/ProtoOdpfMessageParser.java
Show resolved
Hide resolved
src/main/java/io/odpf/sink/connectors/message/proto/ProtoOdpfParsedMessage.java
Show resolved
Hide resolved
lavkesh
force-pushed
the
bq-proto-abstractions
branch
from
5006196 to
2d77c4d
Compare
src/main/java/io/odpf/sink/connectors/expcetion/ConfigurationException.java
Show resolved
Hide resolved
src/main/java/io/odpf/sink/connectors/expcetion/ProtoNotFoundException.java
Show resolved
Hide resolved
| @ConverterClass(InputSchemaDataTypeConverter.class) | ||
| @DefaultValue("PROTOBUF") | ||
| InputSchemaDataType getInputSchemaDataTye(); | ||
| InputSchemaDataType getSinkConnectorSchemaDataTye(); |
There was a problem hiding this comment.
-
There's a typo in the getter name 'Tye'. Also, Do you want to keep Object and Converter class names like this or with prefix 'SinkConnector' ?
-
Unable to comment there so adding it in this thread. Let's keep the key and getter names in sync for line 41
There was a problem hiding this comment.
Right. I will check the configs.
No description provided.