Skip to content

Sink connector small fixes #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lavkesh merged 4 commits into from
May 9, 2022
Merged

Sink connector small fixes #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
52e64db
fix: depedencies and bq metada
lavkesh May 6, 2022
b1ec76a
Merge branch 'main' into sink-connector-feat
lavkesh May 6, 2022
cf07248
chore: small refactoring
lavkesh May 6, 2022
9bd2aa2
Merge branch 'main' into sink-connector-feat
lavkesh May 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/io/odpf/sink/connectors/bigquery/handler/ErrorHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@
import java.util.Map;

public interface ErrorHandler {
void handle(Map<Long, List<BigQueryError>> errorInfoMap, List<Record> records);
default void handle(Map<Long, List<BigQueryError>> errorInfoMap, List<Record> records) {
}
}
9 changes: 0 additions & 9 deletions src/main/java/io/odpf/sink/connectors/bigquery/handler/NoopErrorHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,7 @@
package io.odpf.sink.connectors.bigquery.handler;

import com.google.cloud.bigquery.BigQueryError;
import io.odpf.sink.connectors.bigquery.models.Record;
import lombok.extern.slf4j.Slf4j;

import java.util.List;
import java.util.Map;

@Slf4j
public class NoopErrorHandler implements ErrorHandler {
@Override
public void handle(Map<Long, List<BigQueryError>> errorInfoMap, List<Record> records) {

}
}
2 changes: 2 additions & 0 deletions src/main/java/io/odpf/sink/connectors/message/OdpfMessage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import io.odpf.sink.connectors.common.Tuple;
import io.odpf.sink.connectors.common.TupleString;
import lombok.EqualsAndHashCode;
import lombok.Getter;

import java.util.Arrays;
Expand All @@ -12,6 +13,7 @@


@Getter
@EqualsAndHashCode
public class OdpfMessage {
private final Object logKey;
private final Object logMessage;
Expand Down