fix: Incorrect useRef usage #126
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/progress/4PB1ADCRo2BebGQxATLAyK6MMHuX |
afc163
approved these changes
May 7, 2022
Contributor
|
bump to merge this 🙏 |
Contributor
|
working temporary patch released here for those interested https://www.npmjs.com/package/rc-progress-michelml cc @wanjas |
Contributor
|
@afc163 any reason why this doesn't get merged? The conflix are easy to fix, would you like me to make another PR with the conflicts fixed? |
Member
|
Sure. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this issue #83
If an array is passed as
percentprop and its length is changed dynamically, 'Rendered more hooks than during the previous render' react error appears.The issue was in incorrect
useRefusage silenced by// eslint-disable-next-line react-hooks/rules-of-hooksI believe now it works correctly without any change of actual logic.
I've added 1 test and altered the 'gap' example a bit to check if it is working correctly.