fix: Circle should work correctly in safari with zoom in/out #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
afc163
reviewed
Oct 19, 2022
| return () => { | ||
| window.removeEventListener('resize', calculateTransformOrigin); | ||
| }; | ||
| }, []); |
Member
There was a problem hiding this comment.
这样监听 dom 事件太复杂了，而且用 UA 判断并不可靠，看看有没有更好的兼容方式。
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
==========================================
- Coverage 99.25% 93.50% -5.76%
==========================================
Files 4 4
Lines 135 154 +19
Branches 42 46 +4
==========================================
+ Hits 134 144 +10
- Misses 1 10 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复ant design 中 关于Progress组件在Safari浏览器中，浏览器缩放导致Circle不能正常显示的bug。
相关issue: ant-design/ant-design#38026