Skip to content

fix: precision for ue #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zombieJ merged 1 commit into from
Mar 10, 2025
Merged

fix: precision for ue #1246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/Cell/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,16 @@ function Cell<RecordType>(props: CellProps<RecordType>) {

const [absScroll, scrollWidth] = scrollInfo;

const showStartShadow = isFixStart && fixedStartShadow && absScroll > fixStart;
const showEndShadow = isFixEnd && fixedEndShadow && scrollWidth - absScroll > fixEnd;
const showStartShadow =
(isFixStart && fixedStartShadow && absScroll) -
// For precision, we not show shadow by default which has better user experience.
(fixStart as number) >=
1;
Copy link
Member

@yoyo837 yoyo837 Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

哈哈，安卓滚动有0.几的误差

Copy link
Member Author

@zombieJ zombieJ Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

默认小于 1 的就不展示了，这样也就是少一点距离出现阴影。比永远有阴影舒服，哈哈哈~

const showEndShadow =
(isFixEnd && fixedEndShadow && scrollWidth - absScroll) -
// Same as above
(fixEnd as number) >=
1;

return [showStartShadow, showEndShadow];
});
Expand Down