Road to v0.64 Discussion

[grabbou]

Current latest release: v0.64.0-rc.4

Highlighted Changes

• Hermes opt-in iOS
• Inline requires enabled by default
• new profile-hermes CLI command for converting Hermes tracing profile to Chrome format
• Hermes with Proxy support (will now support react-native-firebase, mobx)
• React 17
• Minimum supported Node version changed to 12
• Remove support of Android API levels 16 through 20. The new minSDK version will be 21+ moving forward
• Use of Xcode 12 and CocoaPods 1.10 is recommended to ensure no errors on iOS

Please see the changelog PR for more details.

Work Required

• Changelog (draft is here)
• Blog post [@grabbou]
• When clicking "Open Debugger" on iOS with Hermes and not having Flipper installed, nothing happens. Perhaps a warning / alert or an appropriate log in the CLI would be helpful to instruct those that don't have Flipper installed on the next steps.
• Dependency on shelljs has been moved from the root package.json into repo-config/package.json (facebook/react-native@f3930a9), causing publish-npm.js script to fail. I have temporarily installed that package on the CircleCI, but would love additional background on the original commit and whether we can safely move it back to the root. fix: release branches miss workspace dependencies facebook/react-native#30472
• Create Xcode project upgrade guide to link to from the Upgrade Helper
• Cut the docs

Already resolved

• Update documentation [@Simek]
• feat: Enable Hermes to work on iOS facebook/react-native#29914
• React 17 support (landed)
• [iOS] Fix cannot working Modal's onDismiss. facebook/react-native#29882
• Fix App Bundle/Release build missing index.android.bundle with gradle plugin 4.1.0+/gradle 6.5 facebook/react-native#30177
• facebook/react-native@a7c1c5a
• Bump CLI to latest
• Migrate warnings in index.js to point to new lean core repos (chore: updated url of deprecated modules facebook/react-native#30422)
• The hermes-engine pod has no version constraints specified, which should probably happen in the React-Core.podspec file and lock it with similar version constraints as the one applied to the Android version in package.json. Fixed by fix: pin hermes-engine to 0.7.x facebook/react-native#30432
• The newly introduced codegen invocation step in the iOS Podfile is failing, as the dependencies of the react-native-codegen package have not been installed. See output here. In progress PR here Integrate Native Module codegen into Xcode build pipeline facebook/react-native#30449
• Trying to build a newly created Android app fails when checking the dynamic libraries for duplicate classes. See output here. Fixed by include android in npm package facebook/react-native#30452
• fix: android artifacts in a release package facebook/react-native#30470
• The new CLI has a minor regression when using a local template dir, now you need to specify the file:// protocol to resolve that [@grabbou] (added note to changelog, this is expected)
• facebook/react-native@d85d5d2
• Update template devDependencies facebook/react-native#30489 (+ make sure to update the changelog as per this comment)
• Bump to Hermes 0.7.2 (What should be included in v0.7.2 facebook/hermes#373) (Bump Hermes to 0.7.2 for v0.64 facebook/react-native#30561)
• Add instructions on how to enable Hermes in the default application Add instructions to template/ios/Podfile for enabling hermes facebook/react-native#30461
• Running pod install outside of ios folder will fail fix(iOS): pod install fails outside ios folder facebook/react-native#30469 (temporary solution, will be fixed by Integrate Native Module codegen into Xcode build pipeline facebook/react-native#30449) - cherry picked facebook/react-native@c901c1f, facebook/react-native@5eee2f2 and facebook/react-native@b61aaa1 for the record.
• Submitting Hermes enabled application to AppStore will fail validation Invalid MinimumOSVersion. Apps that only support 64-bit devices must specify a deployment target of 8.0 or later. MinimumOSVersion in '[My App].app/Frameworks/hermes.framework' is ''." facebook/hermes#420 This isn't a release blocker; this issue is triggered when somebody specifies a higher deployment target than the default and can be solved by the user as shown here.
• fix: default template on iOS facebook/react-native#30571
• Building React Native application in release mode will cause an issue with Xcode 12 After updating to Xcode 12 I get The linked library 'libPods-*****.a' is missing one or more architectures required by this target: arm64. facebook/react-native#29984 (here is a workaround) fix: building in release mode for simulator facebook/react-native#30543
• [0.64.0-rc.1] - KeyboardAvoidingView freezes ios app when wrapped around a scrollview facebook/react-native#30495 (regression)
• Building with Hermes in Release mode (or with "build active architecture" set to false) causes "Thread-local storage is not supported for the current target" in "folly/synchronization/Rcu.cpp:17:10:" and happens while building for "i386". Exclude i386 from valid architectures when building with Hermes on iOS facebook/react-native#30592
• Resolve issues highlighted in the comment Road to v0.64 Discussion #214 (comment)
• facebook/react-native@811ccec
• facebook/react-native@7a9e4ba
• facebook/react-native@f312e5b
• facebook/react-native@f45cb60
• Issue stripping symbols on Android Road to v0.64 Discussion #214 (comment)
• Some users are experiencing issues with CodeGen on iOS due to missing files Road to v0.64 Discussion #214 (comment)

Hopeful Dates

We can never commit to the dates involved in a release as many things are out of our control. However, we are thinking about these rough dates for this release.

• Publish as Release Candidate: Week of January 18th
• Publish as Stable: Beginning of March

[nonewcode]

Thanks to everyone who put in effort to get react native to 0.64

[a-eid]

I'm not able to try this RC release, for some reason I get the following errors.

[mrousavy]

@a-eid take a look at the RN Upgrade Helper to find out what you need to change for this release.

Run

rm -rf node_modules && rm -rf package-lock.json && rm -rf ios/Pods && rm -rf ios/Podfile.lock

and then reinstall everything using

npm i && cd ios && pod repo update && pod update && pod install

I've successfully upgraded to 0.64.0-rc.0 in my project without problems and even managed to get hermes running on iOS with a single line of code (thanks to @grabbou !), so everything seems to work fine

EDIT: To everyone that wants to try out 0.64 rc0 and hermes for iOS, this is how you upgrade:

1. Clean all your caches, Pods/ node_modules, lockfiles
2. Install rn 0.64 rc0 (npm i react-native@next)
3. Update packages/dependencies accordingly, e.g. react to 17, and metro packages to the newest versions
4. Follow this upgrade helper
5. Update your Podfile like this:

-  use_react_native!(:path => config[:reactNativePath])
+  use_react_native!(:path => config[:reactNativePath], :hermes_enabled => true)

Android issues

EDIT 2: Have you guys been able to get 0.64 running on Android? I'm having all kinds of weird errors, such as

• Flipper causing E/SoLoader: couldn't find DSO to load: libfbjni.so
• OkHttp causing E/AndroidRuntime: FATAL EXCEPTION: OkHttp Dispatcher (java.lang.UnsatisfiedLinkError: couldn't find DSO to load: libreactnativejni.so)
• E/SoLoader: couldn't find DSO to load: libjscexecutor.so

[nonewcode]

@a-eid take a look at the RN Upgrade Helper to find out what you need to change for this release.

Run

rm -rf node_modules && rm -rf package-lock.json && rm -rf ios/Pods && rm -rf ios/Podfile.lock

and then reinstall everything using

npm i && cd ios && pod repo update && pod update && pod install

I've successfully upgraded to 0.64.0-rc.0 in my project without problems and even managed to get hermes running on iOS with a single line of code (thanks to @grabbou !), so everything seems to work fine

A quicker trip to this point would be to install react-native-clean-project as a dev dependency and setup the following in package.json:

"scripts": {
  "clean": "react-native clean-project-auto && yarn && yarn pod",
  "pod": "pod install --repo-update --project-directory=ios"
}

Run yarn clean when ever you notice some weird behaviour so you can reset the working directory.

[SConaway]

As with @a-eid , I'm unable to run the newly-created app on Android. Here's the relevant section from adb logcat

Log

--------- beginning of system
11-23 10:27:52.933  3822  3822 D SoLoader: init start
11-23 10:27:52.933  3822  3822 D SoLoader: adding system library source: /vendor/lib
11-23 10:27:52.934  3822  3822 D SoLoader: adding system library source: /system/lib
11-23 10:27:52.934  3822  3822 D SoLoader: adding application source: com.facebook.soloader.DirectorySoSource[root = /data/app/com.rn064-1/lib/arm flags = 0]
11-23 10:27:52.935  3822  3822 D SoLoader: adding backup source from : com.facebook.soloader.ApkSoSource[root = /data/data/com.rn064/lib-main flags = 1]
11-23 10:27:52.935  3822  3822 D SoLoader: Preparing SO source: com.facebook.soloader.DirectorySoSource[root = /system/lib flags = 2]
11-23 10:27:52.935  3822  3822 D SoLoader: Preparing SO source: com.facebook.soloader.DirectorySoSource[root = /system/vendor/lib flags = 2]
11-23 10:27:52.935  3822  3822 D SoLoader: Preparing SO source: com.facebook.soloader.DirectorySoSource[root = /data/app/com.rn064-1/lib/arm flags = 0]
11-23 10:27:52.935  3822  3822 D SoLoader: Preparing SO source: com.facebook.soloader.ApkSoSource[root = /data/data/com.rn064/lib-main flags = 1]
11-23 10:27:52.936  3101  3101 D ImageWallpaper: onVisibilityChanged: mVisible, visible=true, false
11-23 10:27:52.936  3101  3101 D ImageWallpaper: Visibility changed to visible=false
11-23 10:27:52.949  3822  3822 V fb-UnpackingSoSource: locked dso store /data/user/0/com.rn064/lib-main
11-23 10:27:52.951  3822  3822 I fb-UnpackingSoSource: dso store is up-to-date: /data/user/0/com.rn064/lib-main
11-23 10:27:52.951  3822  3822 V fb-UnpackingSoSource: releasing dso store lock for /data/user/0/com.rn064/lib-main
11-23 10:27:52.951  3822  3822 D SoLoader: init finish: 4 SO sources prepared
11-23 10:27:52.951  3822  3822 D SoLoader: init exiting
11-23 10:27:52.955  3822  3822 D SoLoader: init exiting
11-23 10:27:52.955  3822  3822 D SoLoader: About to load: libjscexecutor.so
11-23 10:27:52.956  3822  3822 D SoLoader: libjscexecutor.so not found on /data/data/com.rn064/lib-main
11-23 10:27:52.956  3822  3822 D SoLoader: libjscexecutor.so not found on /data/app/com.rn064-1/lib/arm
11-23 10:27:52.956  3822  3822 D SoLoader: libjscexecutor.so not found on /system/vendor/lib
11-23 10:27:52.956  3822  3822 D SoLoader: libjscexecutor.so not found on /system/lib
11-23 10:27:52.957  3822  3822 W System  : ClassLoader referenced unknown path: 
11-23 10:27:52.960  3822  3822 E SoLoader: couldn't find DSO to load: libjscexecutor.so
11-23 10:27:52.960  3822  3822 E SoLoader: 	SoSource 0: com.facebook.soloader.ApkSoSource[root = /data/data/com.rn064/lib-main flags = 1]
11-23 10:27:52.960  3822  3822 E SoLoader: 	SoSource 1: com.facebook.soloader.DirectorySoSource[root = /data/app/com.rn064-1/lib/arm flags = 0]
11-23 10:27:52.960  3822  3822 E SoLoader: 	SoSource 2: com.facebook.soloader.DirectorySoSource[root = /system/vendor/lib flags = 2]
11-23 10:27:52.960  3822  3822 E SoLoader: 	SoSource 3: com.facebook.soloader.DirectorySoSource[root = /system/lib flags = 2]
11-23 10:27:52.960  3822  3822 E SoLoader: 	Native lib dir: /data/app/com.rn064-1/lib/arm
11-23 10:27:52.960  3822  3822 E SoLoader:  result: 0
11-23 10:27:52.961  3822  3822 D SoLoader: init exiting
11-23 10:27:52.978  3822  3822 D NetworkSecurityConfig: No Network Security Config specified, using platform default
11-23 10:27:52.985  2890  4445 E SensorService: getSensorList a sensor (Sensor Diagnostic Monitor) without holding its required permission: com.samsung.permission.SSENSOR
11-23 10:27:52.985  2890  4445 I SensorService: Skipped sensor Sensor Diagnostic Monitor because it requires permission com.samsung.permission.SSENSOR and app op -1
11-23 10:27:52.994  3822  3822 D SensorManager: registerListener :: 0, LSM6DS3 Accelerometer, 66667, 0,  
11-23 10:27:53.018  3822  3846 D SoLoader: About to load: libfbjni.so
11-23 10:27:53.018  3822  3846 D SoLoader: libfbjni.so not found on /data/data/com.rn064/lib-main
11-23 10:27:53.018  3822  3846 D SoLoader: libfbjni.so not found on /data/app/com.rn064-1/lib/arm
11-23 10:27:53.018  3822  3846 D SoLoader: libfbjni.so not found on /system/vendor/lib
11-23 10:27:53.019  3822  3846 D SoLoader: libfbjni.so not found on /system/lib
11-23 10:27:53.020  3822  3846 E SoLoader: couldn't find DSO to load: libfbjni.so
11-23 10:27:53.020  3822  3846 E SoLoader: 	SoSource 0: com.facebook.soloader.ApkSoSource[root = /data/data/com.rn064/lib-main flags = 1]
11-23 10:27:53.020  3822  3846 E SoLoader: 	SoSource 1: com.facebook.soloader.DirectorySoSource[root = /data/app/com.rn064-1/lib/arm flags = 0]
11-23 10:27:53.020  3822  3846 E SoLoader: 	SoSource 2: com.facebook.soloader.DirectorySoSource[root = /system/vendor/lib flags = 2]
11-23 10:27:53.020  3822  3846 E SoLoader: 	SoSource 3: com.facebook.soloader.DirectorySoSource[root = /system/lib flags = 2]
11-23 10:27:53.020  3822  3846 E SoLoader: 	Native lib dir: /data/app/com.rn064-1/lib/arm
11-23 10:27:53.020  3822  3846 E SoLoader:  result: 0
--------- beginning of crash
11-23 10:27:53.021  3822  3846 E AndroidRuntime: FATAL EXCEPTION: FlipperEventBaseThread
11-23 10:27:53.021  3822  3846 E AndroidRuntime: Process: com.rn064, PID: 3822
11-23 10:27:53.021  3822  3846 E AndroidRuntime: java.lang.UnsatisfiedLinkError: couldn't find DSO to load: libfbjni.so
11-23 10:27:53.021  3822  3846 E AndroidRuntime: 	SoSource 0: com.facebook.soloader.ApkSoSource[root = /data/data/com.rn064/lib-main flags = 1]
11-23 10:27:53.021  3822  3846 E AndroidRuntime: 	SoSource 1: com.facebook.soloader.DirectorySoSource[root = /data/app/com.rn064-1/lib/arm flags = 0]
11-23 10:27:53.021  3822  3846 E AndroidRuntime: 	SoSource 2: com.facebook.soloader.DirectorySoSource[root = /system/vendor/lib flags = 2]
11-23 10:27:53.021  3822  3846 E AndroidRuntime: 	SoSource 3: com.facebook.soloader.DirectorySoSource[root = /system/lib flags = 2]
11-23 10:27:53.021  3822  3846 E AndroidRuntime: 	Native lib dir: /data/app/com.rn064-1/lib/arm
11-23 10:27:53.021  3822  3846 E AndroidRuntime:  result: 0
11-23 10:27:53.021  3822  3846 E AndroidRuntime: 	at com.facebook.soloader.SoLoader.doLoadLibraryBySoName(SoLoader.java:896)
11-23 10:27:53.021  3822  3846 E AndroidRuntime: 	at com.facebook.soloader.SoLoader.loadLibraryBySoNameImpl(SoLoader.java:725)
11-23 10:27:53.021  3822  3846 E AndroidRuntime: 	at com.facebook.soloader.SoLoader.loadLibraryBySoName(SoLoader.java:649)
11-23 10:27:53.021  3822  3846 E AndroidRuntime: 	at com.facebook.soloader.SoLoader.loadLibrary(SoLoader.java:629)
11-23 10:27:53.021  3822  3846 E AndroidRuntime: 	at com.facebook.soloader.NativeLoaderToSoLoaderDelegate.loadLibrary(NativeLoaderToSoLoaderDelegate.java:29)
11-23 10:27:53.021  3822  3846 E AndroidRuntime: 	at com.facebook.soloader.nativeloader.NativeLoader.loadLibrary(NativeLoader.java:51)
11-23 10:27:53.021  3822  3846 E AndroidRuntime: 	at com.facebook.soloader.nativeloader.NativeLoader.loadLibrary(NativeLoader.java:30)
11-23 10:27:53.021  3822  3846 E AndroidRuntime: 	at com.facebook.jni.HybridData.<clinit>(HybridData.java:34)
11-23 10:27:53.021  3822  3846 E AndroidRuntime: 	at com.facebook.flipper.android.FlipperThread.run(FlipperThread.java:25)
11-23 10:27:53.023  2890  3664 D Debug   : !@DumpState : SHIP
11-23 10:27:53.024  2890  3664 D Debug   : !@DumpState : debug level:0x4f4c
11-23 10:27:53.024  2890  3664 D Debug   : !@Dumpstate : Finally, system will skip dumpstate
11-23 10:27:53.024  2890  3664 W ActivityManager:   Force finishing activity com.rn064/.MainActivity
11-23 10:27:53.024  2890  3664 W MultiScreenManagerService: moveTaskBackToDisplayIfNeeded(): root is not base activity
11-23 10:27:53.025  3822  3847 I art     : Rejecting re-init on previously-failed class java.lang.Class<com.facebook.flipper.android.EventBase>: java.lang.UnsatisfiedLinkError: couldn't find DSO to load: libfbjni.so
11-23 10:27:53.025  3822  3847 I art     : 	SoSource 0: com.facebook.soloader.ApkSoSource[root = /data/data/com.rn064/lib-main flags = 1]
11-23 10:27:53.025  3822  3847 I art     : 	SoSource 1: com.facebook.soloader.DirectorySoSource[root = /data/app/com.rn064-1/lib/arm flags = 0]
11-23 10:27:53.025  3822  3847 I art     : 	SoSource 2: com.facebook.soloader.DirectorySoSource[root = /system/vendor/lib flags = 2]
11-23 10:27:53.025  3822  3847 I art     : 	SoSource 3: com.facebook.soloader.DirectorySoSource[root = /system/lib flags = 2]
11-23 10:27:53.025  3822  3847 I art     : 	Native lib dir: /data/app/com.rn064-1/lib/arm
11-23 10:27:53.025  3822  3847 I art     :  result: 0
11-23 10:27:53.025  3822  3847 I art     : (Throwable with no stack trace)
11-23 10:27:53.025  3822  3847 I Process : Sending signal. PID: 3822 SIG: 9

It seems to be unable to find any .so, including JSCExecutor and LibFBNI's.

---

As for iOS, building with or without hermes worked well. I did create a PR to react-native's home repo to add some brief instructions to the template's Podfile. I did encounter an odd warning building for the simulator with hermes:

Odd warning

```

[CP] Vendored binary '/Users/steven/Library/Developer/Xcode/DerivedData/RN064-ehggynwgftmxakbbpchohofnjjxt/Build/Intermediates.noindex/RN064.build/Debug-iphonesimulator/RN064.build/DerivedSources/hermes.framework.dSYM/Contents/Resources/DWARF/hermes' contains architectures (armv7 armv7s arm64) none of which match the current build architectures (x86_64).

<details>

Since it worked, I'm sure there's no reason to be concerned, but just thought I'd bring this up!

[miinos]

Unable to run Android app after upgrade with hermes enabled.
Error: E/SoLoader: couldn't find DSO to load: libjscexecutor.so

[irekrog]

After upgrade from 0.63.3 to this RC I can't open app on Android. This is log from logcat:

--------- beginning of crash
2020-11-23 22:29:24.494 16152-16241/com.myapp E/AndroidRuntime: FATAL EXCEPTION: create_react_context
    Process: com.myapp, PID: 16152
    java.lang.UnsatisfiedLinkError: couldn't find DSO to load: libhermes.so caused by: dlopen failed: library "libc++_shared.so" not found result: 0
        at com.facebook.soloader.SoLoader.doLoadLibraryBySoName(SoLoader.java:896)
        at com.facebook.soloader.SoLoader.loadLibraryBySoNameImpl(SoLoader.java:725)
        at com.facebook.soloader.SoLoader.loadLibraryBySoName(SoLoader.java:649)
        at com.facebook.soloader.SoLoader.loadLibrary(SoLoader.java:629)
        at com.facebook.soloader.SoLoader.loadLibrary(SoLoader.java:577)
        at com.facebook.hermes.reactexecutor.HermesExecutor.<clinit>(HermesExecutor.java:20)
        at com.facebook.hermes.reactexecutor.HermesExecutorFactory.create(HermesExecutorFactory.java:29)
        at com.facebook.react.ReactInstanceManager$5.run(ReactInstanceManager.java:1024)
        at java.lang.Thread.run(Thread.java:929)