Skip to content

fix: Fix Nullability Issues#370

Merged
glennawatson merged 9 commits into
mainfrom
fix-nullability
Apr 10, 2021
Merged

fix: Fix Nullability Issues#370
glennawatson merged 9 commits into
mainfrom
fix-nullability

Conversation

@worldbeater
Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

With the recent Splat update, we now have improved nullable annotations, so Sextant is updated to properly handle them.

@worldbeater
Copy link
Copy Markdown
Contributor Author

worldbeater commented Apr 10, 2021

Stricter null checks discovered a few issues that could lead to NullReferenceExceptions in unit tests, so probably worth fixing the unit tests as well. A few test cases don't seem to be correctly set up, and hence they're now failing due to the new null guards.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 10, 2021

Codecov Report

Merging #370 (690ae28) into main (a05e65e) will increase coverage by 2.07%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
+ Coverage   66.87%   68.95%   +2.07%     
==========================================
  Files          31       30       -1     
  Lines         809      802       -7     
==========================================
+ Hits          541      553      +12     
+ Misses        268      249      -19     
Impacted Files Coverage Δ
src/Sextant/DefaultViewModelFactory.cs 0.00% <0.00%> (ø)
...extant.XamForms/Mixins/DependencyResolverMixins.cs 89.65% <100.00%> (+5.44%) ⬆️
src/Sextant/DependencyResolverMixins.cs 57.57% <100.00%> (+1.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a05e65e...690ae28. Read the comment docs.

@worldbeater worldbeater marked this pull request as ready for review April 10, 2021 13:27
@glennawatson glennawatson merged commit 5b775e3 into main Apr 10, 2021
@glennawatson glennawatson deleted the fix-nullability branch April 10, 2021 13:46
@reactiveui reactiveui locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants