Skip to content

Conversation

@mustafamilyas
Copy link
Contributor

@mustafamilyas mustafamilyas commented Apr 25, 2023

This is PR for translating the Describing the UI page

Closes #464

CHANGES

  • translate src/content/learn/describing-the-ui.md

Copy link
Contributor

@fzn0x fzn0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Butuh sedikit improvisasi pada kalimat

@resir014
Copy link
Member

@mustafamilyas FYI, the layout translations are meant to be translated at the end, after all the page contents are translated. But since you already started ahead, let's continue with it!

@mustafamilyas
Copy link
Contributor Author

@mustafamilyas FYI, the layout translations are meant to be translated at the end, after all the page contents are translated. But since you already started ahead, let's continue with it!

I see2, should I continue to translate the layout or can we leave this as it is? @resir014

@mustafamilyas mustafamilyas requested a review from fzn0x April 26, 2023 08:31
@mazipan
Copy link
Collaborator

mazipan commented Apr 26, 2023

Should we revert all changes except the MD files for now @resir014? It keep us to focus on the related content.

@resir014
Copy link
Member

I see2, should I continue to translate the layout or can we leave this as it is?

@mustafamilyas Leave them as it is for now. Current focus is the documentation contents (i.e. everyting in content folder).

@resir014
Copy link
Member

Should we revert all changes except the MD files for now @resir014? It keep us to focus on the related content.

Yep, I think it's better we do that. @mazipan @mustafamilyas

@mustafamilyas
Copy link
Contributor Author

Should we revert all changes except the MD files for now @resir014? It keep us to focus on the related content.

Yep, I think it's better we do that. @mazipan @mustafamilyas

done ya 🙏 ,

mustafamilyas and others added 23 commits April 29, 2023 14:13
@r17x
Copy link
Collaborator

r17x commented Apr 29, 2023

I see 3 Approvals for this PRs. So, I rebase and merged

Thank you all

@github-actions
Copy link

github-actions bot commented Apr 29, 2023

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@r17x r17x merged commit 1d989ab into reactjs:main Apr 29, 2023
r17x pushed a commit that referenced this pull request May 8, 2023
Co-authored-by: Resi Respati <[email protected]>
Co-authored-by: Arfian Adam <[email protected]>
Co-authored-by: Irfan Maulana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Describing the UI

7 participants