Skip to content

docs: translate Thinking in React #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
r17x merged 7 commits into from
Apr 30, 2023
Merged

docs: translate Thinking in React #358

r17x merged 7 commits into from
Apr 30, 2023

Conversation

@resir014
Copy link
Member

@resir014 resir014 commented Apr 27, 2023 •
edited
Loading

Translated the "Thinking in React" page to Indonesian.

Closes #374.

@github-actions
Copy link

github-actions bot commented Apr 27, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@resir014 resir014 mentioned this pull request Apr 27, 2023
Open
@resir014 resir014 changed the title Translate Thinking in React docs: tanslate Thinking in React Apr 28, 2023
@github-actions
Copy link

github-actions bot commented Apr 28, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions
Copy link

github-actions bot commented Apr 28, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@resir014 resir014 changed the title docs: tanslate Thinking in React docs: translate Thinking in React Apr 28, 2023
@github-actions
Copy link

github-actions bot commented Apr 29, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@resir014 resir014 marked this pull request as ready for review April 29, 2023 03:58
@resir014
Copy link
Member Author

resir014 commented Apr 29, 2023

@mhaidarhanif @r17x @zainfathoni Ready to review.

@github-actions
Copy link

github-actions bot commented Apr 29, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions
Copy link

github-actions bot commented Apr 29, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mhaidarhanif
mhaidarhanif requested changes Apr 29, 2023
View reviewed changes
Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some early suggestions and feedback to discuss.

@github-actions
Copy link

github-actions bot commented Apr 29, 2023 •
edited
Loading

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mhaidarhanif
mhaidarhanif requested changes Apr 29, 2023
View reviewed changes
Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another suggestion is to make the reading flow better.

r17x
r17x requested changes Apr 29, 2023
View reviewed changes
mhaidarhanif
mhaidarhanif approved these changes Apr 29, 2023
View reviewed changes
Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready, but maybe there are some things to check again. Wait for the others.

r17x
r17x requested changes Apr 29, 2023
View reviewed changes
Copy link
Collaborator

@r17x r17x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • word for "state" -> *state*
  • word for "merender" -> me-*render*

@resir014 resir014 requested a review from r17x April 30, 2023 05:53
@r17x r17x force-pushed the translate-thinking-in-react branch from af1f93a to a6e48a3 Compare April 30, 2023 12:09
@r17x r17x merged commit 5930a03 into main Apr 30, 2023
r17x added a commit that referenced this pull request May 8, 2023
@resir014 @mhaidarhanif @r17x
docs: translate Thinking in React (#358)
4f40a57 
Co-authored-by: M Haidar Hanif <[email protected]>
Co-authored-by: RiN <[email protected]>
@r17x r17x deleted the translate-thinking-in-react branch July 13, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhaidarhanif mhaidarhanif mhaidarhanif approved these changes

@r17x r17x r17x approved these changes

@zainfathoni zainfathoni Awaiting requested review from zainfathoni

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Thinking in React

3 participants

@resir014 @mhaidarhanif @r17x