Translate two articles (JSX and curly braces) #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Writing Markup with JSX - JavaScript in JSX with Curly Braces
Member
Author
|
https://ja-beta-reactjs-org-kvts9dqap-fbopensource.vercel.app/learn/writing-markup-with-jsx しっかりブランチプレビューも動作しているようです |
Member
Author
|
相変わらず「Analyze Bundle / analyze (pull_request) 」のActionが動かないですね… main ブランチで作られたアーチファクトを取りに行こうとして not found と言われているようです。 アーチファクトの保持期間自体はデフォルトの90日に設定されていたので、アーチファクトが本当に消えているというよりはパーミッション系の問題？ |
Member
Author
|
そもそも |
koba04
approved these changes
Dec 23, 2021
Member
koba04
left a comment
koba04
left a comment
There was a problem hiding this comment.
ありがとうございます！
一点、nits なコメントしましたが Approve するので適用するかはお任せします！
Co-authored-by: Toru Kobayashi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ブランチプレビューのテストも兼ねています