Skip to content
This repository was archived by the owner on Jul 19, 2019. It is now read-only.

Conversation

@merlinstardust
Copy link

Fixes #183

@davideghz
Copy link

When will this fix be merged?

@filipebarcos
Copy link

Why not change components to use js classes instead?

@merlinstardust
Copy link
Author

@filipebarcos This is a faster fix to get the warning removed. Replacing it with JS classes will require an actual refactor

@igorshmukler
Copy link

@merlinpatt thank you for the commit. would love to see this merged, so the warning will be gone. IMHO, in a long-term refactoring perhaps is better. however, in a near-term, eliminating the warning will definitely be beneficial, to me, at least.

@msteward
Copy link

msteward commented Jun 1, 2017

Agree that this is the simplest low-risk fix for the short term to help users of the library continue to use it whilst preparing for React 16

@dmason30
Copy link

@arjunskumar47 @austinpray can we get this in as a priority?

@austinpray austinpray merged commit e317447 into reactjs:chartjs-v2 Jun 29, 2017
@rgranger
Copy link

Hi guys ! Can we get this into the master branch ? So people using React 16 can also use this module ?

@kdejaeger
Copy link

Is there another package on npm compatible with this fix? Kinda need it for a react update to v16.

@rgranger
Copy link

https://github.com/jerairrest/react-chartjs-2

Look for equivalent packages on npms.io ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants