fix(remove-forward-ref): preserve union and intersection types#339
Open
iamakulov wants to merge 1 commit intoreactjs:masterfrom
Open
fix(remove-forward-ref): preserve union and intersection types#339iamakulov wants to merge 1 commit intoreactjs:masterfrom
iamakulov wants to merge 1 commit intoreactjs:masterfrom
Conversation
Previously, the codemod would drop union (|) and intersection (&) types
from props when transforming forwardRef components, leaving components
without proper type annotations.
Now supports:
- Union types: ButtonProps | LinkProps
- Intersection types: BaseProps & MetaProps
- Complex nested combinations
Example transformation:
```typescript
// Before
React.forwardRef<HTMLElement, BaseProps & MetaProps>((props, ref) => ...)
// After
({ ref, ...props }: BaseProps & MetaProps & { ref: React.RefObject<HTMLElement> }) => ...
```
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
Author
|
(Note: these tests will need to be updated a bit ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the codemod would drop union (|) and intersection (&) types from props when transforming
forwardRefcomponents, leaving components without proper type annotations:This PR fixes this, adding proper support for union and intersection types.