Add semi-colons to generated JavaScript #941
Conversation
BookOfGreg
left a comment
BookOfGreg
left a comment
There was a problem hiding this comment.
Looks good, yep we might as well generate code that passes most people's linters. Thanks for contributing.
There's one small change in the gemspec that looks unintentional, if you could revert that we can get these changes in.
react-rails.gemspec
Outdated
| s.add_development_dependency 'selenium-webdriver' | ||
| s.add_development_dependency 'test-unit', '~> 2.5' | ||
| s.add_development_dependency 'rails', '>= 3.2' | ||
| s.add_development_dependency 'turbolinks' |
There was a problem hiding this comment.
This file probably wants to be reset, turbolinks isn't a dependency of this project.
There was a problem hiding this comment.
I see your commit eeef8a3 mentions tests failing without turbolinks but the build before yours ran green. What are you referring to?
There was a problem hiding this comment.
@BookOfGreg The first time I ran the tests on my machine (I assume they're ran with a simple rake ?) I was getting tons of errors about not being able to resolve Turbolinks on the controller tests.
I can roll it back if you want.
There was a problem hiding this comment.
Yes please. The tests that matter for this project are the ones on Travis. Rake should work locally when using Appraise but it's easy to pollute the environment on this project accidentally.
This reverts commit eeef8a3.
|
@BookOfGreg reverted. |
|
Thank you Ben 👍 |
2 participants
Summary
Add semi-colons to generated JavaScript which is created when using the generator.
Seems like good practice and I always end up doing this myself after running the generator anyway for the sake of cleanliness. May as well fix it at the source, eh?
Other Information
N/A