Skip to content

Update dependency react/promise to v3 #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WyriHaximus merged 1 commit into from
Dec 9, 2023
Merged

Update dependency react/promise to v3 #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"ext-parallel": "*",
"react-parallel/event-loop": "dev-master as 2.0",
"react/event-loop": "^1.1",
"react/promise": "^2.7",
"react/promise": "^2.7 || ^3.0",
"wyrihaximus/constants": "^1.6"
},
"require-dev": {
Expand Down
19 changes: 10 additions & 9 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 0 additions & 7 deletions tests/RuntimeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,15 @@

use parallel\Runtime\Error\Closed;
use React\EventLoop\Loop;
use React\Promise\ExtendedPromiseInterface;
use ReactParallel\EventLoop\EventLoopBridge;
use ReactParallel\Runtime\Runtime;
use TheOrville\Exceptions\LatchcombException;
use WyriHaximus\AsyncTestUtilities\AsyncTestCase;

use function assert;
use function React\Async\await;
use function sleep;
use function WyriHaximus\React\timedPromise;

/** @internal */
final class RuntimeTest extends AsyncTestCase
{
/** @test */
Expand All @@ -30,7 +27,6 @@ public function convertSuccess(): void

return 3;
});
assert($promise instanceof ExtendedPromiseInterface);

$promise->always(static function () use ($runtime): void {
$runtime->kill();
Expand All @@ -54,7 +50,6 @@ public function convertFailure(): void

throw new LatchcombException('Rethrow exception');
});
assert($promise instanceof ExtendedPromiseInterface);

$promise->always(static function () use ($runtime): void {
$runtime->close();
Expand All @@ -78,7 +73,6 @@ public function weClosedTheThread(): void
return 3;
});
});
assert($promise instanceof ExtendedPromiseInterface);

Loop::futureTick(static function () use ($runtime): void {
$runtime->close();
Expand All @@ -100,7 +94,6 @@ public function weKilledTheThread(): void
return 3;
});
});
assert($promise instanceof ExtendedPromiseInterface);

Loop::futureTick(static function () use ($runtime): void {
$runtime->kill();
Expand Down