Replace colon with underscore in caching filePath (and a few other characters) #6358
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
approved these changes
Nov 25, 2025
Contributor
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
Ugh, yes, this is horrible character to use in the file path. : serves as the ADS delimiter on Windows and some other file systems also dislike this character I believe.
Here's an example of your CHANGELOG entry: * Replace colon with underscore in caching filePath.
[roman-bcny](https://github.com/roman-bcny)
[#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)note: There are two invisible spaces after the entry's text. Generated by 🚫 Danger |
SimplyDanny
reviewed
Nov 27, 2025
Collaborator
SimplyDanny
left a comment
SimplyDanny
left a comment
There was a problem hiding this comment.
There're even more characters allowed in a URL that must not be used in a "universal" file path. I think those are
< > : " / \ | ? *
and trailing dots .. Since we're already on it, we may replace them too.
roman-bcny
changed the title
Contributor
Author
|
@SimplyDanny makes sense, updated |
SimplyDanny
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this we end up with a file name
http__:sitewhich doesn't work on Windows and crashesConfigurationTests.testValidRemoteChildConfigwith abort() which fast-exits resulting in partial test resultsWith this change I'm able to run swift test on Windows to completion (x64 6.2.1):
cc @compnerd