Expose CloseAndReconnect method#18
Merged
loeffel-io merged 1 commit intorecws-org:masterfrom Jan 27, 2020
Merged
Conversation
The method seems to have been accidentally not exposed since the comment is uppercase but the function name is lowercase and all the other methods seems to match their comment and function name casing. Even if not, this can be useful to the users - a server might send some kind of a `reconnect` order that dictates the client to terminate the connection and reconnect.
uskudnik
force-pushed
the
expose-close-and-reconnect
branch
from
f183876 to
f80bd30
Compare
|
bump |
loeffel-io
approved these changes
Nov 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method seems to have been accidentally not exposed since the comment is uppercase but the function name is lowercase and all the other methods seems to match their comment and function name casing.
Even if not, this can be useful to the users - a server might send some kind of a
reconnectorder that dictates the client to terminate the connection and reconnect.