fix: improve error handling for empty clusters#51
Merged
rm3l merged 3 commits intoredhat-developer:mainfrom Jan 13, 2026
Merged
fix: improve error handling for empty clusters#51rm3l merged 3 commits intoredhat-developer:mainfrom
rm3l merged 3 commits intoredhat-developer:mainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
PR images are available (for 1 week): |
- gather_helm: Check if standalone_dir exists before running find command to avoid pipeline failure due to set -o pipefail - gather_operator: Check if Backstage CRD exists before querying CRs and validate JSON output before parsing with jq to prevent parse errors - common.sh: Only log ERR trap messages in debug/trace mode to avoid confusing users with expected failures (e.g., resource not found) These changes fix misleading error messages when running must-gather on clusters without RHDH installed.
rm3l
force-pushed
the
fix/fix_confusing_warnings_in_output_with_jq
branch
from
fc3f7bb to
50009d6
Compare
|
PR images are available (for 1 week): |
- Operator CRs: Wait for pods to be Running instead of CR Deployed condition - Standalone Helm: Wait for Running phase instead of Ready condition - PostgreSQL: Wait for Running phase instead of Ready condition - Increase timeouts from 60s to 120s for pod discovery This makes E2E tests more resilient by not requiring pods to be fully Ready (which depends on readiness probes passing). Just Running is sufficient for must-gather to collect data.
- Move replicas:2 from StatefulSet CR to Deployment CR for better test coverage - Wait for both pods to be Running before proceeding - Update validation to expect 2 replicas for Deployment CR, 1 for StatefulSet CR - Update process validation to check for expected replica count
|
PR images are available (for 1 week): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to avoid pipeline failure due to set -o pipefail
validate JSON output before parsing with jq to prevent parse errors
confusing users with expected failures (e.g., resource not found)
These changes fix misleading error messages when running must-gather
on clusters without RHDH installed.
Description
Which issue(s) does this PR fix or relate to
PR acceptance criteria
How to test changes / Special notes to the reviewer