Conversation
We changed this to `HIREDIS_SSL`
This reduces the boilerplate of all the redisConnectXXX functions, and allows us to provide more connection options in the future.
also, clean up redisContextInit -- we're just zeoring the struct
If callback was set before scheduleTimer was set (i..e before one of the attach()) calls.
This will avoid the need to constantly reschedule the event
This helps us detect use-after-free
also, indentation fix
Closed
inbaryuval
approved these changes
Feb 20, 2019
| redisLibeventEvents *e = (redisLibeventEvents*)arg; | ||
| redisAsyncHandleRead(e->context); | ||
| static void redisLibeventDestroy(redisLibeventEvents *e) { | ||
| free(e); |
There was a problem hiding this comment.
set data in ac to NULL (e->context->ev.data = NULL)
- it is safer
- once we would add libeventDetach it would be very important (Redislabs needs it)
This was referenced Feb 27, 2019
This was referenced Mar 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds SSL support, but also a rehaul of option parsing, as well as the ability to use timeouts in async mode.