Simplify model_key_prefix default #522
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Closing this PR due to staleness (18 months). The feature request is now tracked in #741. Thank you @frozenBranch for raising this! The simplification makes sense, but it's a breaking change that needs careful consideration around migration paths and potential name collisions. See #741 for continued discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm proposing this change to make sure that the default value for model_key_prefix is useful for non-advanced users.
Currently the model_key_prefix default value includes the modules path, which is inconvinient if the path of the model changes (could be the file name or some parent folder).
This change would make it a bit more similar to how traditional SQL ORM's handle table names, the index name by default would just be :ModelName: