Skip to content

tests/kgo: handle errors when polling for verifier status #27013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nvartolomei merged 2 commits into from
Jul 30, 2025
Merged

tests/kgo: handle errors when polling for verifier status #27013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9dff319
tests/kgo: handle errors when polling for verifier status
mmaslankaprv Jul 28, 2025
c7237ba
tests: upgrade kgo-verifier with startup race condition fix
nvartolomei Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/docker/ducktape-deps/kgo-verifier
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
set -e
git -C /opt clone https://github.com/redpanda-data/kgo-verifier.git
cd /opt/kgo-verifier
git reset --hard 319c69da3d7690e26d390261c4b331703b99260c
git reset --hard f97884cb0815d60eca41950f818d51c70b665890
go mod tidy
make
17 changes: 14 additions & 3 deletions tests/rptest/services/kgo_verifier_services.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,13 @@
import threading
import requests
from typing import Any, Dict, Optional
from requests.adapters import HTTPAdapter

from ducktape.cluster.cluster import ClusterNode
from ducktape.services.service import Service
from ducktape.utils.util import wait_until
from ducktape.cluster.remoteaccount import RemoteCommandError
from urllib3 import Retry

from rptest.services.redpanda import RedpandaService

Expand Down Expand Up @@ -442,11 +444,20 @@ def _ingest_status(self, worker_statuses):
self._parent._status = reduced

def poll_status(self):
retry_strategy = Retry(total=5,
connect=5,
read=5,
backoff_factor=0.3,
status=5,
allowed_methods=['GET'],
status_forcelist=[503, 504])
session = requests.Session()
session.mount("http://", HTTPAdapter(max_retries=retry_strategy))

while not self._stop_requested.is_set():
drop_out = self._shutdown_requested.is_set()

r = requests.get(self._parent._remote_url(self._node, "status"),
timeout=5)
r = session.get(url=self._parent._remote_url(self._node, "status"),
timeout=5)
r.raise_for_status()
worker_statuses = r.json()
self._ingest_status(worker_statuses)
Expand Down