Skip to content

[v25.2.x] [CORE-13087] dl/coordinator: don't purge data when dropping Glue table#27380

Merged
andrwng merged 2 commits intoredpanda-data:v25.2.xfrom
vbotbuildovich:backport-pr-27367-v25.2.x-684
Aug 26, 2025
Merged

[v25.2.x] [CORE-13087] dl/coordinator: don't purge data when dropping Glue table#27380
andrwng merged 2 commits intoredpanda-data:v25.2.xfrom
vbotbuildovich:backport-pr-27367-v25.2.x-684

Conversation

@vbotbuildovich
Copy link
Copy Markdown
Collaborator

Backport of PR #27367

We'll need another kludge for Glue (to not purge tables when dropping,
which isn't currently supported by Glue), so this pulls out the
Glue-detecting logic for reuse in a subsequent commit.

(cherry picked from commit 60093e7)
Glue doesn's support the purgeRequested option when dropping tables, and
will reject our requests indefinitely when a tombstone exists. This ends
up blocking topic tombstone removal, and therefore blocks subsequent
Iceberg topics of the same name from translating any data.

This commit plumbs a bool to the drop_table() command that is false for
Glue.

I considered doing this in the catalog layer, but opted to be more
explicit (it's hopeflly less surprising for readers that way).

Manually tested this against Glue:
1. create an Iceberg topic
2. produce to the Iceberg topic and wait for Iceberg commits
3. drop the Iceberg topic
4. witness the drop table op eventually succeeding in Glue
5. manually delete the data in Iceberg
6. recreate the topic and produce without issues

...as well as another sequence where I didn't do step 4 and instead
immediately went on to delete data and recreate the topic. In both
cases, the Redpanda coordinator was not blocked and could produce to the
new topic without issues.

(cherry picked from commit dac3524)
@vbotbuildovich vbotbuildovich added this to the v25.2.x-next milestone Aug 26, 2025
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Aug 26, 2025
@vbotbuildovich vbotbuildovich requested a review from andrwng August 26, 2025 15:54
@andrwng andrwng enabled auto-merge August 26, 2025 16:11
@vbotbuildovich
Copy link
Copy Markdown
Collaborator Author

CI test results

test results on build#71399
test_class test_method test_arguments test_kind job_url test_status passed reason
RandomNodeOperationsTest test_node_operations {"cloud_storage_type": 2, "compaction_mode": "chunked_sliding_window", "enable_failures": true, "mixed_versions": false, "with_iceberg": false} integration https://buildkite.com/redpanda/redpanda/builds/71399#0198e73a-0937-4cbf-acf6-ee6a69ac1775 FLAKY 18/21 upstream reliability is '100.0'. current run reliability is '85.71428571428571'. drift is 14.28571 and the allowed drift is set to 50. The test should PASS
TopicDeleteCloudStorageTest drop_lifecycle_marker_test {"cloud_storage_type": 1} integration https://buildkite.com/redpanda/redpanda/builds/71399#0198e73d-d783-4a49-8d90-f11f4181a704 FLAKY 20/21 upstream reliability is '98.21428571428571'. current run reliability is '95.23809523809523'. drift is 2.97619 and the allowed drift is set to 50. The test should PASS

@andrwng andrwng merged commit 4960e9a into redpanda-data:v25.2.x Aug 26, 2025
17 checks passed
@BenPope BenPope modified the milestones: v25.2.x-next, v25.2.3 Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/redpanda kind/backport PRs targeting a stable branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants