[v25.2.x] iceberg: couple logging improvements#27743
Merged
Merged
Conversation
It's very verbose as is. (cherry picked from commit a493a7f)
CONFLICT: - minor conflict in rest_client/BUILD When there is an error returned from the REST catalog, we have very little context about what we sent. This commit addresses this by logging the logical contents of the request as JSON. I considered logging at a lower level, and logging the entire HTTP request payload (e.g. in perform_request() after signing and such), but opted to place the at the callsite because the context we have there is already const and available to be logged conditionally (vs in perform_request(), the request is moved, making conditional logging trickier). (cherry picked from commit e315237)
andrwng
force-pushed
the
25-2-x-iceberg-log-tweak
branch
from
f6f6318 to
22e1536
Compare
Collaborator
Retry command for Build#73029please wait until all jobs are finished before running the slash command |
Collaborator
CI test resultstest results on build#73029
|
oleiman
approved these changes
Sep 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #27715
CONFLICT: