rptest: add "assert-ref-snapshot-id" to log allow list#27758
Merged
rockwotj merged 1 commit intoredpanda-data:devfrom Sep 26, 2025
Merged
rptest: add "assert-ref-snapshot-id" to log allow list#27758rockwotj merged 1 commit intoredpanda-data:devfrom
rockwotj merged 1 commit intoredpanda-data:devfrom
Conversation
Now that we are logging the body of failed requests to the Iceberg REST
catalog, we may end up with bad log line test failures that complain
about messages with the following substring:
```
..."requirements":[{"type":"assert-ref-snapshot-id","ref":"main","snapshot-id":3902887918253494995}]...
```
This commit adds such messages to the allowed list.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new regex pattern to the log allow list to prevent test failures when Iceberg REST catalog error messages containing "assert-ref-snapshot-id" appear in logs. The change allows tests to continue running without false positives from these benign error messages that occur during Iceberg catalog operations.
Key Changes:
- Adds regex pattern for "assert-ref-snapshot-id" to the log allow list in the Redpanda test service
nvartolomei
approved these changes
Sep 26, 2025
joe-redpanda
approved these changes
Sep 26, 2025
7 tasks
Contributor
|
Looks like CI failed on Which afaik is flakey, can we override merge this? |
Collaborator
CI test resultstest results on build#73074
|
Collaborator
|
/backport v25.2.x |
Collaborator
|
/backport v25.1.x |
Collaborator
|
Failed to create a backport PR to v25.1.x branch. I tried: |
Collaborator
|
Failed to create a backport PR to v25.2.x branch. I tried: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we are logging the body of failed requests to the Iceberg REST catalog, we may end up with bad log line test failures that complain about messages with the following substring:
This commit adds such messages to the allowed list.
Backports Required
Release Notes