Skip to content

rptest: add "assert-ref-snapshot-id" to log allow list#27758

Merged
rockwotj merged 1 commit intoredpanda-data:devfrom
andrwng:allow-assert-ref-snap
Sep 26, 2025
Merged

rptest: add "assert-ref-snapshot-id" to log allow list#27758
rockwotj merged 1 commit intoredpanda-data:devfrom
andrwng:allow-assert-ref-snap

Conversation

@andrwng
Copy link
Copy Markdown
Contributor

@andrwng andrwng commented Sep 26, 2025

Now that we are logging the body of failed requests to the Iceberg REST catalog, we may end up with bad log line test failures that complain about messages with the following substring:

..."requirements":[{"type":"assert-ref-snapshot-id","ref":"main","snapshot-id":3902887918253494995}]...

This commit adds such messages to the allowed list.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v25.2.x
  • v25.1.x
  • v24.3.x

Release Notes

  • None

Now that we are logging the body of failed requests to the Iceberg REST
catalog, we may end up with bad log line test failures that complain
about messages with the following substring:

```
..."requirements":[{"type":"assert-ref-snapshot-id","ref":"main","snapshot-id":3902887918253494995}]...
```

This commit adds such messages to the allowed list.
Copilot AI review requested due to automatic review settings September 26, 2025 16:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new regex pattern to the log allow list to prevent test failures when Iceberg REST catalog error messages containing "assert-ref-snapshot-id" appear in logs. The change allows tests to continue running without false positives from these benign error messages that occur during Iceberg catalog operations.

Key Changes:

  • Adds regex pattern for "assert-ref-snapshot-id" to the log allow list in the Redpanda test service

@andrwng andrwng enabled auto-merge September 26, 2025 16:30
@joe-redpanda
Copy link
Copy Markdown
Contributor

Looks like CI failed on

test_id:    rptest.tests.workload_upgrade_runner_test.RedpandaUpgradeTest.test_workloads_through_releases.cloud_storage_type=CloudStorageType.S3

Which afaik is flakey, can we override merge this?

@vbotbuildovich
Copy link
Copy Markdown
Collaborator

CI test results

test results on build#73074
test_class test_method test_arguments test_kind job_url test_status passed reason test_history
ShadowLinkingReplicationTests test_replication_basic {"shuffle_leadership": true, "source_cluster_spec": {"cluster_type": "kafka", "kafka_quorum": "COMBINED_KRAFT", "kafka_version": "3.8.0"}} integration https://buildkite.com/redpanda/redpanda/builds/73074#019986f3-da6b-4ef7-bcd9-4b15ba0cf499 FLAKY 11/21 upstream reliability is '86.29856850715747'. current run reliability is '52.38095238095239'. drift is 33.91762 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=ShadowLinkingReplicationTests&test_method=test_replication_basic
TimeQueryTest test_timequery_with_local_gc null integration https://buildkite.com/redpanda/redpanda/builds/73074#019986ed-9d66-4ebf-aa29-20ec50d98f30 FLAKY 19/21 upstream reliability is '96.41509433962264'. current run reliability is '90.47619047619048'. drift is 5.9389 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=TimeQueryTest&test_method=test_timequery_with_local_gc

@rockwotj rockwotj disabled auto-merge September 26, 2025 19:08
@rockwotj rockwotj merged commit 08fe378 into redpanda-data:dev Sep 26, 2025
15 of 18 checks passed
@vbotbuildovich
Copy link
Copy Markdown
Collaborator

/backport v25.2.x

@vbotbuildovich
Copy link
Copy Markdown
Collaborator

/backport v25.1.x

@vbotbuildovich
Copy link
Copy Markdown
Collaborator

Failed to create a backport PR to v25.1.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-27758-v25.1.x-557 remotes/upstream/v25.1.x
git cherry-pick -x ec0f03fb29

Workflow run logs.

@vbotbuildovich
Copy link
Copy Markdown
Collaborator

Failed to create a backport PR to v25.2.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-27758-v25.2.x-431 remotes/upstream/v25.2.x
git cherry-pick -x ec0f03fb29

Workflow run logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants