[v25.1.x] datalake: clean up files after translation error#27766
Merged
andrwng merged 2 commits intoredpanda-data:v25.1.xfrom Sep 27, 2025
Merged
[v25.1.x] datalake: clean up files after translation error#27766andrwng merged 2 commits intoredpanda-data:v25.1.xfrom
andrwng merged 2 commits intoredpanda-data:v25.1.xfrom
Conversation
This will be useful to inject transient errors to the record multiplexer (e.g. schema registry errors) to fail translation, rather than DLQ records. Will be used in an upcoming test to ensure we clean up local files after such a failure. (cherry picked from commit c253a2e)
CONFLICTS: - this branch doesn't have some logging at the top of finish() - different formatting in this branch in translation_task_test - this branch is missing a test in record_multiplexer_test that was affected by the signature change of finish() - translation task doesn't take features table as an argument We previously didn't clean up files record_multiplexer::finish() returned errors. Since the returned success result is previously what held the local files, this commit updates the signature to collect the files in finish() (regardless of whether the operation succeeds or not), and cleans up the files in translation_task::finish() and ::discard(). (cherry picked from commit fd496bc)
andrwng
force-pushed
the
v25.1.x-27737
branch
from
741b9f6 to
0d61970
Compare
Collaborator
CI test resultstest results on build#73101
|
oleiman
approved these changes
Sep 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #27737