[v25.2.x] [CORE-13370] archival: Fence spillover command#27889
Merged
Lazin merged 1 commit intoredpanda-data:v25.2.xfrom Oct 4, 2025
Merged
[v25.2.x] [CORE-13370] archival: Fence spillover command#27889Lazin merged 1 commit intoredpanda-data:v25.2.xfrom
Lazin merged 1 commit intoredpanda-data:v25.2.xfrom
Conversation
Also, extract fence initialization into a method in the ntp_archiver to avoid code duplication. There is a change in the control flow in the 'apply_spillover' method. Previously, the spillover wouldn't stop in case of replication error causing the error to be repeated. The loop would use manifest to create a spillover manifest and replicate the command with archival STM. The replicate method waits until the command is applied and propagates the error back to the loop. In case of error the error was printed and the loop continued. Since the state of the manifest didn't change the loop would produce the same manifesta and the same command causing new failure. This commit breaks if the spillover command can't be applied. This guarantees forward progress. Signed-off-by: Evgeny Lazin <4lazin@gmail.com> (cherry picked from commit 35dc6d6)
Lazin
changed the title
Collaborator
CI test resultstest results on build#73536
|
oleiman
approved these changes
Oct 3, 2025
Member
oleiman
left a comment
oleiman
left a comment
There was a problem hiding this comment.
sorry, though i approved this already
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #27714