[CORE-14466] ts: Fix spillover race#28281
Merged
Lazin merged 3 commits intoredpanda-data:devfrom Oct 30, 2025
Merged
Conversation
Signed-off-by: Evgeny Lazin <4lazin@gmail.com>
If the metadata is not replicated or applied in time we shouldn't proceed to spillover. Signed-off-by: Evgeny Lazin <4lazin@gmail.com>
If archive retention fails due to replication timeout fail the whole housekeeping round. Signed-off-by: Evgeny Lazin <4lazin@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses race conditions in the spillover handling of the NTP archiver service by downgrading a spillover invariant violation from an error to a warning and adding exception throwing for failed archive operations. The changes help prevent race conditions when replication of archival STM commands times out but are still applied asynchronously.
Key Changes
- Downgrades spillover invariant violation log from error to warning level
- Adds exception throwing for failed archive retention and garbage collection operations
- Improves error handling consistency across archival operations
Collaborator
CI test resultstest results on build#75314
|
Collaborator
|
/backport v25.2.x |
Collaborator
|
/backport v25.1.x |
Collaborator
|
Failed to create a backport PR to v25.1.x branch. I tried: |
This was referenced Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Backports Required
Release Notes