Skip to content

[v25.2.x] [CORE-15247] kafka: add size validation to string & arrays read off the wire#29228

Merged
michael-redpanda merged 3 commits into
redpanda-data:v25.2.xfrom
vbotbuildovich:backport-pr-29208-v25.2.x-476
Jan 12, 2026
Merged

[v25.2.x] [CORE-15247] kafka: add size validation to string & arrays read off the wire#29228
michael-redpanda merged 3 commits into
redpanda-data:v25.2.xfrom
vbotbuildovich:backport-pr-29208-v25.2.x-476

Conversation

@vbotbuildovich
Copy link
Copy Markdown
Collaborator

Backport of PR #29208

@vbotbuildovich vbotbuildovich added this to the v25.2.x-next milestone Jan 12, 2026
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Jan 12, 2026
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Jan 12, 2026
WillemKauf and others added 3 commits January 12, 2026 09:14
For string, array, and number of tags.

(cherry picked from commit 13d3f76)
Add wire_validation_test.cc with tests that verify bounds checking
and error handling in the Kafka protocol decoder. Tests cover:
- Array length validation (exceeds buffer, negative, max int32)
- Flex array validation (exceeds buffer, zero length)
- String/flex string validation (exceeds buffer, negative/zero length)
- Bytes/flex bytes validation
- Tagged fields validation (count exceeds buffer, duplicate/non-ascending
  IDs, size exceeds buffer)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
(cherry picked from commit a78c238)
@WillemKauf WillemKauf force-pushed the backport-pr-29208-v25.2.x-476 branch from 531d820 to 4405497 Compare January 12, 2026 14:14
@vbotbuildovich
Copy link
Copy Markdown
Collaborator Author

Retry command for Build#78894

please wait until all jobs are finished before running the slash command

/ci-repeat 1
skip-redpanda-build
skip-units
skip-rebase
tests/rptest/tests/random_node_operations_test.py::RandomNodeOperationsTest.test_node_operations@{"cloud_storage_type":2,"compaction_mode":"sliding_window","enable_failures":false,"mixed_versions":true,"with_iceberg":false}

@WillemKauf
Copy link
Copy Markdown
Contributor

/ci-repeat 1
skip-redpanda-build
skip-units
skip-rebase
tests/rptest/tests/random_node_operations_test.py::RandomNodeOperationsTest.test_node_operations@{"cloud_storage_type":2,"compaction_mode":"sliding_window","enable_failures":false,"mixed_versions":true,"with_iceberg":false}

1 similar comment
@WillemKauf
Copy link
Copy Markdown
Contributor

/ci-repeat 1
skip-redpanda-build
skip-units
skip-rebase
tests/rptest/tests/random_node_operations_test.py::RandomNodeOperationsTest.test_node_operations@{"cloud_storage_type":2,"compaction_mode":"sliding_window","enable_failures":false,"mixed_versions":true,"with_iceberg":false}

@WillemKauf
Copy link
Copy Markdown
Contributor

ci-repeats dont work :(

@michael-redpanda michael-redpanda merged commit 4c60a13 into redpanda-data:v25.2.x Jan 12, 2026
14 of 18 checks passed
@tyson-redpanda tyson-redpanda modified the milestones: v25.2.x-next, v25.2.14 Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build area/redpanda kind/backport PRs targeting a stable branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants