[v25.1.x] CORE-14617 kafka: fix fetch session retry losing partition inclusion#29364
Closed
pgellert wants to merge 1 commit into
Closed
[v25.1.x] CORE-14617 kafka: fix fetch session retry losing partition inclusion#29364pgellert wants to merge 1 commit into
pgellert wants to merge 1 commit into
Conversation
When fetches retry internally due to min_bytes not being satisfied, partitions with changed metadata were incorrectly excluded from the response. The issue was that update_fetch_partition() both checked whether a partition should be included AND mutated the session cache. On retry, the cache already reflected the response, so no change was detected. Split into partition_has_changes() for the check in set() and update_session_partition() for the mutation in send_response(). Also re-enables the source_high_watermark check in cluster linking tests. (cherry picked from commit b7c6970) (cherry picked from commit 7da2330)
pgellert
requested review from
a team and
michael-redpanda
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #29304
The conflict was on the cluster linking test + the nearby
fetch_response_bytes_eq_unitstest infetch_test.ccnot existing on v25.2.x.Fixes #29351