[v25.3.x] Fix case where messages can be written multiple times in Iceberg#29397
Merged
piyushredpanda merged 3 commits intoredpanda-data:v25.3.xfrom Feb 7, 2026
Merged
Conversation
(cherry picked from commit c7c8c5c)
Callers of `serde_parquet_writer::add_data_struct` assume that the data struct wasn't successfully written to the file if `writer_error::ok` isn't returned. However, it's possible for `_writer.write_row(...)` to be successful then have some disk/memory reservation error. Prior to this commit these errors would result in the message being written twice as the callers would assume that the first write had failed. (cherry picked from commit efc3a22)
In a previous commit `serde_parquet_writer` was changed to always return an `ok` result when the record is written. This resulted in the flush at the translation_task level to no longer return a no data error. The unit test is therefore modified in this commit to reflect the new behavior. (cherry picked from commit 7f506e3)
Collaborator
Author
CI test resultstest results on build#79627
|
piyushredpanda
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #29251