[v25.1.x] CORE-15421: add protovalidate as well-known type#29419
Closed
michael-redpanda wants to merge 1 commit into
Closed
[v25.1.x] CORE-15421: add protovalidate as well-known type#29419michael-redpanda wants to merge 1 commit into
michael-redpanda wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR backports support for protovalidate as a well-known type in Redpanda's schema registry. The change enables the schema registry to recognize and handle buf/validate protobuf imports without requiring explicit references.
Changes:
- Added
protovalidateas a Bazel dependency - Registered
buf.validate.Ruleas a known protobuf type in the schema registry - Added comprehensive test coverage for protovalidate functionality
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| MODULE.bazel | Adds protovalidate v1.0.0 as a new Bazel dependency |
| src/v/pandaproxy/BUILD | Adds protovalidate proto library to pandaproxy dependencies |
| src/v/pandaproxy/schema_registry/protobuf.cc | Registers buf::validate::Rule as a known type and includes the validate.pb.h header |
| src/v/pandaproxy/schema_registry/test/compatibility_protobuf.cc | Extends compatibility tests with buf/validate field types |
| tests/rptest/tests/schema_registry_test.py | Adds Python test case validating protovalidate schema registration and retrieval |
Contributor
Author
|
Conflicts:
|
Add buf/validate/validate.proto as a well-known type in schema registry so that schemas importing protovalidate validation rules can be registered without explicitly providing references. Changes: - Add protovalidate bazel dependency (version 1.0.0) - Add validate_proto_cc to schema_registry:core implementation_deps - Include buf/validate/validate.pb.h and add to known_types set - Add unit test coverage in test_protobuf_well_known - Add integration test in schema_registry_test.py Signed-off-by: Michael Boquard <michael@redpanda.com> (cherry picked from commit 4cbe872)
michael-redpanda
force-pushed
the
manual-backport-29404-v25.1.x-726
branch
from
24e0a2f to
0aa7d36
Compare
rockwotj
reviewed
Jan 27, 2026
Contributor
rockwotj
left a comment
rockwotj
left a comment
There was a problem hiding this comment.
25.1 doesn't use bazel so I just don't think this is worth backporting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #29404