Skip to content

[v25.3.x] rptests/util/repeat_check: make it work correctly in wait_until#29607

Merged
bashtanov merged 1 commit intoredpanda-data:v25.3.xfrom
vbotbuildovich:backport-pr-29602-v25.3.x-144
Feb 20, 2026
Merged

[v25.3.x] rptests/util/repeat_check: make it work correctly in wait_until#29607
bashtanov merged 1 commit intoredpanda-data:v25.3.xfrom
vbotbuildovich:backport-pr-29602-v25.3.x-144

Conversation

@vbotbuildovich
Copy link
Copy Markdown
Collaborator

@vbotbuildovich vbotbuildovich commented Feb 17, 2026

Backport of PR #29602

@bashtanov @vbotbuildovich
rptests/util/repeat_check: make it work correctly in wait_until
504a0ed 
`repeat_check` wrapper is for checking that a condition used in
`wait_until` or `wait_until_result` is stable and returns True multiple
times in a line. Due to a typo, it only checked once in case of
`wait_until`, as (False, False) evaluates as True. Fix that.

(cherry picked from commit 668b829)
@vbotbuildovich vbotbuildovich added this to the v25.3.x-next milestone Feb 17, 2026
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Feb 17, 2026
@bashtanov bashtanov enabled auto-merge February 17, 2026 10:17
@vbotbuildovich
Copy link
Copy Markdown
Collaborator Author

vbotbuildovich commented Feb 17, 2026 •
edited
Loading

Retry command for Build#80573

please wait until all jobs are finished before running the slash command

/ci-repeat 1
skip-redpanda-build
skip-units
skip-rebase
tests/rptest/tests/cluster_linking_omb_test.py::ClusterLinkingOMBTest.test_omb
tests/rptest/tests/datalake/datalake_omb_test.py::DatalakeOMBTest.basic_workload_linear_20_test@{"cloud_storage_type":1}
tests/rptest/tests/services_self_test.py::OpenBenchmarkSelfTest.test_default_omb_configuration@{"driver":"SIMPLE_DRIVER","workload":"SIMPLE_WORKLOAD"}

@vbotbuildovich
Copy link
Copy Markdown
Collaborator Author

vbotbuildovich commented Feb 17, 2026 •
edited
Loading

CI test results

test results on build#80573
test_class test_method test_arguments test_kind job_url test_status passed reason test_history
ClusterLinkingOMBTest test_omb null integration https://buildkite.com/redpanda/redpanda/builds/80573#019c6b30-23a7-4012-b62c-082106f670fb FAIL 0/11 Test FAILS after retries.Significant increase in flaky rate(baseline=0.0000, p0=0.0000, reject_threshold=0.0100) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=ClusterLinkingOMBTest&test_method=test_omb
ClusterLinkingOMBTest test_omb null integration https://buildkite.com/redpanda/redpanda/builds/80573#019c6b32-f9af-48c1-b639-b85f0c8b8c41 FAIL 0/11 Test FAILS after retries.Significant increase in flaky rate(baseline=0.0000, p0=0.0000, reject_threshold=0.0100) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=ClusterLinkingOMBTest&test_method=test_omb
DatalakeOMBTest basic_workload_linear_20_test {"cloud_storage_type": 1} integration https://buildkite.com/redpanda/redpanda/builds/80573#019c6b30-23aa-4842-9841-f336c1ecc6bc FAIL 0/11 Test FAILS after retries.Significant increase in flaky rate(baseline=0.0000, p0=0.0000, reject_threshold=0.0100) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=DatalakeOMBTest&test_method=basic_workload_linear_20_test
DatalakeOMBTest basic_workload_linear_20_test {"cloud_storage_type": 1} integration https://buildkite.com/redpanda/redpanda/builds/80573#019c6b32-f9b1-4dda-9ef9-b5ceeb509edc FAIL 0/11 Test FAILS after retries.Significant increase in flaky rate(baseline=0.0000, p0=0.0000, reject_threshold=0.0100) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=DatalakeOMBTest&test_method=basic_workload_linear_20_test
NodesDecommissioningTest test_decommission_status null integration https://buildkite.com/redpanda/redpanda/builds/80573#019c6b30-23a5-484a-ba9f-292364fcb9dc FLAKY 10/11 Test PASSES after retries.No significant increase in flaky rate(baseline=0.0000, p0=1.0000, reject_threshold=0.0100. adj_baseline=0.1000, p1=0.3487, trust_threshold=0.5000) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=NodesDecommissioningTest&test_method=test_decommission_status
OpenBenchmarkSelfTest test_default_omb_configuration {"driver": "SIMPLE_DRIVER", "workload": "SIMPLE_WORKLOAD"} integration https://buildkite.com/redpanda/redpanda/builds/80573#019c6b32-f9ac-48aa-85f6-01076ea5169e FAIL 0/11 Test FAILS after retries.Significant increase in flaky rate(baseline=0.0000, p0=0.0000, reject_threshold=0.0100) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=OpenBenchmarkSelfTest&test_method=test_default_omb_configuration
test results on build#80577
test_class test_method test_arguments test_kind job_url test_status passed reason test_history
ClusterLinkingOMBTest test_omb null integration https://buildkite.com/redpanda/redpanda/builds/80577#019c6b7d-fc3a-4f85-8e46-deea93f7a205 FAIL 0/11 Test FAILS after retries.Significant increase in flaky rate(baseline=0.0000, p0=0.0000, reject_threshold=0.0100) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=ClusterLinkingOMBTest&test_method=test_omb
ClusterLinkingOMBTest test_omb null integration https://buildkite.com/redpanda/redpanda/builds/80577#019c6b7d-fc3e-457f-9cf3-9a34b64f4531 FAIL 0/11 Test FAILS after retries.Significant increase in flaky rate(baseline=0.0000, p0=0.0000, reject_threshold=0.0100) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=ClusterLinkingOMBTest&test_method=test_omb
DatalakeOMBTest basic_workload_linear_20_test {"cloud_storage_type": 1} integration https://buildkite.com/redpanda/redpanda/builds/80577#019c6b7d-fc3a-4f85-8e46-deea93f7a205 FAIL 0/11 Test FAILS after retries.Significant increase in flaky rate(baseline=0.0000, p0=0.0000, reject_threshold=0.0100) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=DatalakeOMBTest&test_method=basic_workload_linear_20_test
DatalakeOMBTest basic_workload_linear_20_test {"cloud_storage_type": 1} integration https://buildkite.com/redpanda/redpanda/builds/80577#019c6b7d-fc3e-457f-9cf3-9a34b64f4531 FAIL 0/11 Test FAILS after retries.Significant increase in flaky rate(baseline=0.0000, p0=0.0000, reject_threshold=0.0100) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=DatalakeOMBTest&test_method=basic_workload_linear_20_test
OpenBenchmarkSelfTest test_default_omb_configuration {"driver": "SIMPLE_DRIVER", "workload": "SIMPLE_WORKLOAD"} integration https://buildkite.com/redpanda/redpanda/builds/80577#019c6b7d-fc3e-457f-9cf3-9a34b64f4531 FAIL 0/11 Test FAILS after retries.Significant increase in flaky rate(baseline=0.0000, p0=0.0000, reject_threshold=0.0100) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=OpenBenchmarkSelfTest&test_method=test_default_omb_configuration
test results on build#80763
test_class test_method test_arguments test_kind job_url test_status passed reason test_history
ClusterLinkingOMBTest test_omb null integration https://buildkite.com/redpanda/redpanda/builds/80763#019c7688-6c90-4e30-ac0d-41dfbd2ed5f2 FAIL 0/11 Test FAILS after retries.Significant increase in flaky rate(baseline=0.0000, p0=0.0000, reject_threshold=0.0100) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=ClusterLinkingOMBTest&test_method=test_omb
ClusterLinkingOMBTest test_omb null integration https://buildkite.com/redpanda/redpanda/builds/80763#019c7689-9374-4e89-9325-7d99c1b1c329 FAIL 0/11 Test FAILS after retries.Significant increase in flaky rate(baseline=0.0000, p0=0.0000, reject_threshold=0.0100) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=ClusterLinkingOMBTest&test_method=test_omb
DatalakeOMBTest basic_workload_linear_20_test {"cloud_storage_type": 1} integration https://buildkite.com/redpanda/redpanda/builds/80763#019c7688-6c93-4fa3-ba72-66a5f4b7938d FAIL 0/11 Test FAILS after retries.Significant increase in flaky rate(baseline=0.0000, p0=0.0000, reject_threshold=0.0100) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=DatalakeOMBTest&test_method=basic_workload_linear_20_test
DatalakeOMBTest basic_workload_linear_20_test {"cloud_storage_type": 1} integration https://buildkite.com/redpanda/redpanda/builds/80763#019c7689-9376-4bc9-8d2e-7d7d1ffd0184 FAIL 0/11 Test FAILS after retries.Significant increase in flaky rate(baseline=0.0000, p0=0.0000, reject_threshold=0.0100) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=DatalakeOMBTest&test_method=basic_workload_linear_20_test
OpenBenchmarkSelfTest test_default_omb_configuration {"driver": "SIMPLE_DRIVER", "workload": "SIMPLE_WORKLOAD"} integration https://buildkite.com/redpanda/redpanda/builds/80763#019c7688-6c8c-4c40-bf8f-943c16d05141 FAIL 0/11 Test FAILS after retries.Significant increase in flaky rate(baseline=0.0000, p0=0.0000, reject_threshold=0.0100) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=OpenBenchmarkSelfTest&test_method=test_default_omb_configuration
WriteCachingFailureInjectionE2ETest test_crash_all {"use_transactions": false} integration https://buildkite.com/redpanda/redpanda/builds/80763#019c7688-6c8d-45b9-add2-01cce05d9d41 FLAKY 10/11 Test PASSES after retries.No significant increase in flaky rate(baseline=0.1463, p0=1.0000, reject_threshold=0.0100. adj_baseline=0.3779, p1=0.0087, trust_threshold=0.5000) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=WriteCachingFailureInjectionE2ETest&test_method=test_crash_all
test results on build#80863
test_class test_method test_arguments test_kind job_url test_status passed reason test_history
FollowerFetchingTest test_basic_follower_fetching {"fetch_from": "fetch-from-local"} integration https://buildkite.com/redpanda/redpanda/builds/80863#019c7bfe-6523-4473-adf3-87a9084f3278 FLAKY 10/11 Test PASSES after retries.No significant increase in flaky rate(baseline=0.0000, p0=1.0000, reject_threshold=0.0100. adj_baseline=0.1000, p1=0.3487, trust_threshold=0.5000) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=FollowerFetchingTest&test_method=test_basic_follower_fetching
TestReadReplicaService test_writes_forbidden {"cloud_storage_type": 1, "partition_count": 10} integration https://buildkite.com/redpanda/redpanda/builds/80863#019c7bfe-6523-488f-ac3c-ca3b7dc67066 FLAKY 10/11 Test PASSES after retries.No significant increase in flaky rate(baseline=0.0000, p0=1.0000, reject_threshold=0.0100. adj_baseline=0.1000, p1=0.3487, trust_threshold=0.5000) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=TestReadReplicaService&test_method=test_writes_forbidden

@bashtanov
Copy link
Copy Markdown
Contributor

bashtanov commented Feb 17, 2026

/ci-repeat 1
skip-redpanda-build
skip-units
skip-rebase
tests/rptest/tests/cluster_linking_omb_test.py::ClusterLinkingOMBTest.test_omb
tests/rptest/tests/datalake/datalake_omb_test.py::DatalakeOMBTest.basic_workload_linear_20_test@{"cloud_storage_type":1}
tests/rptest/tests/services_self_test.py::OpenBenchmarkSelfTest.test_default_omb_configuration@{"driver":"SIMPLE_DRIVER","workload":"SIMPLE_WORKLOAD"}

@vbotbuildovich
Copy link
Copy Markdown
Collaborator Author

vbotbuildovich commented Feb 17, 2026 •
edited
Loading

Retry command for Build#80577

please wait until all jobs are finished before running the slash command

/ci-repeat 1
skip-redpanda-build
skip-units
skip-rebase
tests/rptest/tests/cluster_linking_omb_test.py::ClusterLinkingOMBTest.test_omb
tests/rptest/tests/datalake/datalake_omb_test.py::DatalakeOMBTest.basic_workload_linear_20_test@{"cloud_storage_type":1}
tests/rptest/tests/services_self_test.py::OpenBenchmarkSelfTest.test_default_omb_configuration@{"driver":"SIMPLE_DRIVER","workload":"SIMPLE_WORKLOAD"}

@bashtanov
Copy link
Copy Markdown
Contributor

bashtanov commented Feb 17, 2026

something is wrong with OMB in 25.3.x
@mmaslankaprv could you force-merge please?

@michael-redpanda
Copy link
Copy Markdown
Contributor

michael-redpanda commented Feb 17, 2026

something is wrong with OMB in 25.3.x @mmaslankaprv could you force-merge please?

@bashtanov yeah that started happening sometime in the last couple of weeks, myself and Ioannis have some stuck backports on 25.3 and 25.2

@bashtanov
Copy link
Copy Markdown
Contributor

bashtanov commented Feb 19, 2026

/dt

@vbotbuildovich
Copy link
Copy Markdown
Collaborator Author

vbotbuildovich commented Feb 19, 2026 •
edited
Loading

Retry command for Build#80763

please wait until all jobs are finished before running the slash command

/ci-repeat 1
skip-redpanda-build
skip-units
skip-rebase
tests/rptest/tests/cluster_linking_omb_test.py::ClusterLinkingOMBTest.test_omb
tests/rptest/tests/datalake/datalake_omb_test.py::DatalakeOMBTest.basic_workload_linear_20_test@{"cloud_storage_type":1}
tests/rptest/tests/services_self_test.py::OpenBenchmarkSelfTest.test_default_omb_configuration@{"driver":"SIMPLE_DRIVER","workload":"SIMPLE_WORKLOAD"}

@bashtanov
Copy link
Copy Markdown
Contributor

bashtanov commented Feb 20, 2026

/dt

@bashtanov bashtanov merged commit 23667c4 into redpanda-data:v25.3.x Feb 20, 2026
19 checks passed
@piyushredpanda piyushredpanda modified the milestones: v25.3.x-next, v25.3.8 Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bashtanov bashtanov bashtanov approved these changes

Assignees

No one assigned

Labels

kind/backport PRs targeting a stable branch

Projects

None yet

Milestone

v25.3.8

Development

Successfully merging this pull request may close these issues.

4 participants

@vbotbuildovich @bashtanov @michael-redpanda @piyushredpanda