[v25.3.x] CORE-15587 proto: allow large TLS certs in shadow link#29746
Merged
pgellert merged 2 commits intoredpanda-data:v25.3.xfrom Mar 3, 2026
Merged
Conversation
The lookup_field() generator was missing .share() for string fields with (redpanda.core.pbgen.iobuf) = true. Since iobuf is move-only, this caused compile errors. Fix by checking isIOBuf(f) alongside the existing BytesKind check. (cherry picked from commit 8547e15)
Shadow link TLS PEM fields (ca, key, cert) were limited to 128KiB by proto serde's string size limit. Large CA bundles with multiple certificates could exceed this, causing deserialization failures. Add (redpanda.core.pbgen.iobuf) = true annotation to these fields in TLSPEMSettings proto. Update shadow_link converter to use iobuf_to_string() for conversions. This allows arbitrarily large PEM data while maintaining sstring API compatibility. (cherry picked from commit 34090ee)
pgellert
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #29718